Skip to content

Commit 6b317ed

Browse files
committed
fix: address PR review comments
Guard the pgrep/ps snippet in the public skill so it does not error when RocketSim is not running. Fix the repeated numbered list item in the README Claude Code install instructions.
1 parent 827e6ca commit 6b317ed

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Agent-Skill/SKILL.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ Developer machines can have multiple RocketSim installs side-by-side, such as an
1616
If RocketSim is already running, prefer that app bundle first:
1717

1818
```bash
19-
APP_PATH="$(ps -o command= -p "$(pgrep -x RocketSim | head -1)" | sed 's#/Contents/MacOS/RocketSim$##')"
19+
ROCKETSIM_PID="$(pgrep -x RocketSim | head -1)"
20+
APP_PATH=""
21+
if [ -n "$ROCKETSIM_PID" ]; then
22+
APP_PATH="$(ps -o command= -p "$ROCKETSIM_PID" | sed 's#/Contents/MacOS/RocketSim$##')"
23+
fi
2024
printf '%s\n' "$APP_PATH"
2125
```
2226

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ To install this skill for your personal use in Claude Code:
6565
/plugin marketplace add AvdLee/RocketSimApp
6666
```
6767

68-
1. Install the skill:
68+
2. Install the skill:
6969

7070
```bash
7171
/plugin install rocketsim@rocketsim

0 commit comments

Comments
 (0)