PR Feedback

Signed-off-by: Cole Gentry <peapod2007@gmail.com>

Author: SomethingNew71

src/app.rs

@@ -1360,6 +1360,12 @@ impl UltraLogApp {
         }
     }
 
+    /// Stop playback and reset the frame timer
+    fn stop_playback(&mut self) {
+        self.is_playing = false;
+        self.last_frame_time = None;
+    }
+
     // ========================================================================
     // Keyboard Shortcuts
     // ========================================================================
@@ -1439,8 +1445,7 @@ impl UltraLogApp {
 
             // Arrow Left - step one record backward (Shift = 10 records)
             if i.key_pressed(egui::Key::ArrowLeft) {
-                self.is_playing = false;
-                self.last_frame_time = None;
+                self.stop_playback();
                 if let Some(tab_idx) = self.active_tab {
                     let file_index = self.tabs[tab_idx].file_index;
                     if file_index < self.files.len() {
@@ -1459,8 +1464,7 @@ impl UltraLogApp {
 
             // Arrow Right - step one record forward (Shift = 10 records)
             if i.key_pressed(egui::Key::ArrowRight) {
-                self.is_playing = false;
-                self.last_frame_time = None;
+                self.stop_playback();
                 if let Some(tab_idx) = self.active_tab {
                     let file_index = self.tabs[tab_idx].file_index;
                     if file_index < self.files.len() {
@@ -1479,8 +1483,7 @@ impl UltraLogApp {
 
             // Home - jump to start of log
             if i.key_pressed(egui::Key::Home) {
-                self.is_playing = false;
-                self.last_frame_time = None;
+                self.stop_playback();
                 if let Some((min, _)) = self.get_time_range() {
                     self.set_cursor_time(Some(min));
                     let record = self.find_record_at_time(min);
@@ -1491,8 +1494,7 @@ impl UltraLogApp {
 
             // End - jump to end of log
             if i.key_pressed(egui::Key::End) {
-                self.is_playing = false;
-                self.last_frame_time = None;
+                self.stop_playback();
                 if let Some((_, max)) = self.get_time_range() {
                     self.set_cursor_time(Some(max));
                     let record = self.find_record_at_time(max);

src/ui/chart.rs

@@ -110,6 +110,8 @@ impl UltraLogApp {
         // Fixed Y bounds for normalized data (0-1 with small padding)
         const Y_MIN: f64 = -0.05;
         const Y_MAX: f64 = 1.05;
+        /// Sensitivity multiplier for scroll-to-zoom (higher = faster zoom per scroll tick)
+        const SCROLL_ZOOM_SENSITIVITY: f64 = 0.003;
 
         // Build the plot - X-axis zoom only, Y fixed
         // When scroll_to_zoom is enabled, disable scroll-to-pan so we handle scroll as zoom
@@ -182,7 +184,8 @@ impl UltraLogApp {
             // Apply scroll-to-zoom: use scroll delta to zoom centered on pointer
             if scroll_to_zoom && scroll_delta_y.abs() > 0.1 {
                 if let Some((min_t, max_t)) = time_range {
-                    let zoom_factor = (1.0 - scroll_delta_y as f64 * 0.003).clamp(0.8, 1.25);
+                    let zoom_factor =
+                        (1.0 - scroll_delta_y as f64 * SCROLL_ZOOM_SENSITIVITY).clamp(0.8, 1.25);
                     let width = x_max - x_min;
                     let new_width = (width * zoom_factor).clamp(0.01, max_t - min_t);