Problems with docker-compose.yml AND .env

[ovizii]

What is the point of setting all those variables up inside .env when some of them are never referenced inside the docker-compose.yml file? And some others, are statically overwritten inside the compose file. No wonder the issues are full of people complaining they can't change a single variable and have to stick to the defaults.

AFAIK, and please correct me if there's anything wrong but:

The files referenced in the instructions: https://codewithcj.github.io/SparkyFitness/install/docker-compose point to these two files:

• https://github.com/CodeWithCJ/SparkyFitness/releases/latest/download/docker-compose.prod.yml
• https://github.com/CodeWithCJ/SparkyFitness/releases/latest/download/default.env.example

Now I had set these two inside .env:

SPARKY_FITNESS_DISABLE_EMAIL_LOGIN=true
SPARKY_FITNESS_OIDC_AUTO_REDIRECT=true

And was wondering why Email Login was still enabled, and it was not automatically redirecting to OIDC when I realized that these two variables were not declared under the environment: section. Since I didn't feel like double-checking each variable one by one and there are a lot, I added them to each container's like this: env_file: .env

And it gets even better. Inside .env we have stuff like:

# The external port the server will be exposed on.
SPARKY_FITNESS_SERVER_PORT=3010
SPARKY_FITNESS_SERVER_HOST=sparkyfitness-server

BUT inside docker-compose.yml we have this declared statically:

SPARKY_FITNESS_SERVER_PORT: 3010
SPARKY_FITNESS_SERVER_HOST: sparkyfitness-server

And what is that comment supposed to mean "# The external port the server will be exposed on." - that sounds highly incorrect. The external port the server will be exposed needs to be set like this inside the compose file:

    ports:
      - "3004:3010"

or maybe like this:

    ports:
      - "${SPARKY_FITNESS_SERVER_PORT}:80"

But in the compose file, the port isn't even exposed.

I hope nobody feels offended, but I just wasted like 3 hours on sparkyfitness for no good reason :-(