NotifyCanExecuteChangedFor and inheritance

[michaelmairegger]

I have the following classes:

public partial class ListAdminViewModel<TSelectorObject> :  ObservableObject
{
        [ObservableProperty]
        private TSelectorObject? _currentItem;
}

public partial class InvoiceAdminViewModel : ListAdminViewModel<Invoice>
{
    [RelayCommand(CanExecute = nameof(CanTransferInvoice))]
    private async Task SendElectronicInvoice()
    {
        ....
    }

    private bool CanTransferInvoice()
    {
        return CurrentItem is { IsTransfered: false} ;
    }
}

How it is possible to use [NotifyCanExecuteChangedFor(nameof(SendElectronicInvoiceCommand))] without the following workaround:

protected override void OnPropertyChanged(PropertyChangedEventArgs e)
{
    base.OnPropertyChanged(e);
    if (e.PropertyName == nameof(CurrentItem))
    {
        SendElectronicInvoiceCommand.NotifyCanExecuteChanged();
    }
}

[michaelmairegger]

Any news on this?

Further code sample:

public partial class Parent : ObservableObject
{
    [ObservableProperty]
    [NotifyCanExecuteChangedFor(nameof(TestBaseCommand))]
    public virtual partial string? CurrentItem { get; set; }

    [RelayCommand] // this command is not considered when using NotifyCanExecuteChangedFor
    private void TestBase()
    {

    }
}

public partial class Child : Parent
{
    [ObservableProperty]
    [NotifyCanExecuteChangedFor(nameof(TestChildCommand))]
    public override partial string? CurrentItem { get; set; }

    [RelayCommand] // this command is considered when using NotifyCanExecuteChangedFor
    private void TestChild()
    {
    }
}

as the code generator uses field in Child class and not the base property.

[echoix]

What I can think of as an explanation is that the override in the property makes the attribute of the base class not added. On your child class, why not add this too: [NotifyCanExecuteChangedFor(nameof(TestBaseCommand))] ?

[michaelmairegger]

I don't want it to add just for convenience, and this breakes DRY. And if in some cases the logic of base class changes and an attribute is removed then nothing will prevent the child class from having this duplicate attribute.