fix(import-markdown): address review comments from PR #589

Addressing rwmjhb's CHANGES_REQUESTED review:

- MR1: catch 改為僅處理 EISDIR，其他 I/O 錯誤（權限、損壞）重新拋出
- F2: foundFiles++ 移至 stat + isFile() 檢查之後，確保只計入實際檔案
- MR2: import-markdown CI entry 移至 cli-smoke 之前，確保 cli-smoke 失敗時仍會執行
- F1: 修復 vacuously-true 斷言 assert.ok(skipped >= 0) → assert.strictEqual(skipped, 1)

Author: jlin53882

cli.ts

@@ -658,7 +658,6 @@ export async function runImportMarkdown(
 
   // Parse each file for memory entries (lines starting with "- ")
   for (const { filePath, scope: discoveredScope } of mdFiles) {
-    foundFiles++;
     let content: string;
     try {
       const stats = await fsPromises.stat(filePath);
@@ -668,10 +667,19 @@ export async function runImportMarkdown(
         skipped++;
         continue;
       }
+      foundFiles++; // count only actual files, not directories
       content = await fsPromises.readFile(filePath, "utf-8");
     } catch (err) {
-      console.warn(`  [skip] unreadable: ${filePath} — ${err}`);
-      skipped++;
+      const e = err as NodeJS.ErrnoException;
+      if (e.code === "EISDIR") {
+        // .md directory — already handled above by isFile() check, but catch
+        // this explicitly so genuine I/O errors (permissions, corruption)
+        // are not silently swallowed
+        console.warn(`  [skip] not a file: ${filePath}`);
+        skipped++;
+      } else {
+        throw err; // re-throw genuine I/O errors
+      }
       continue;
     }
  (fix(import-markdown): CI測試登記 + .md目錄skip保護)

scripts/ci-test-manifest.mjs

@@ -18,13 +18,12 @@ export const CI_TEST_MANIFEST = [
   { group: "core-regression", runner: "node", file: "test/recall-text-cleanup.test.mjs", args: ["--test"] },
   { group: "storage-and-schema", runner: "node", file: "test/update-consistency-lancedb.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/strip-envelope-metadata.test.mjs", args: ["--test"] },
+  { group: "cli-smoke", runner: "node", file: "test/import-markdown/import-markdown.test.mjs", args: ["--test"] },
   { group: "cli-smoke", runner: "node", file: "test/cli-smoke.mjs" },
   { group: "cli-smoke", runner: "node", file: "test/functional-e2e.mjs" },
-  { group: "cli-smoke", runner: "node", file: "test/import-markdown/import-markdown.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/retriever-rerank-regression.mjs" },
   { group: "core-regression", runner: "node", file: "test/smart-memory-lifecycle.mjs" },
   { group: "core-regression", runner: "node", file: "test/smart-extractor-branches.mjs" },
- (fix(import-markdown): CI測試登記 + .md目錄skip保護)
   { group: "packaging-and-workflow", runner: "node", file: "test/plugin-manifest-regression.mjs" },
   { group: "core-regression", runner: "node", file: "test/session-summary-before-reset.test.mjs", args: ["--test"] },
   { group: "packaging-and-workflow", runner: "node", file: "test/sync-plugin-version.test.mjs", args: ["--test"] },
@@ -42,16 +41,12 @@ export const CI_TEST_MANIFEST = [
   { group: "storage-and-schema", runner: "node", file: "test/cross-process-lock.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/preference-slots.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/is-latest-auto-supersede.test.mjs" },
-<<<<<<< HEAD
   { group: "core-regression", runner: "node", file: "test/hook-dedup-phase1.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/temporal-awareness.test.mjs", args: ["--test"] },
   // Issue #598 regression tests
   { group: "core-regression", runner: "node", file: "test/store-serialization.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/access-tracker-retry.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/embedder-cache.test.mjs" },
-=======
-  { group: "core-regression", runner: "node", file: "test/temporal-awareness.test.mjs", args: ["--test"] },
->>>>>>> 1a83d72 (fix(import-markdown): CI測試登記 + .md目錄skip保護)
 ];
 
 export function getEntriesForGroup(group) {

scripts/verify-ci-test-manifest.mjs

@@ -19,13 +19,12 @@ const EXPECTED_BASELINE = [
   { group: "core-regression", runner: "node", file: "test/recall-text-cleanup.test.mjs", args: ["--test"] },
   { group: "storage-and-schema", runner: "node", file: "test/update-consistency-lancedb.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/strip-envelope-metadata.test.mjs", args: ["--test"] },
+  { group: "cli-smoke", runner: "node", file: "test/import-markdown/import-markdown.test.mjs", args: ["--test"] },
   { group: "cli-smoke", runner: "node", file: "test/cli-smoke.mjs" },
   { group: "cli-smoke", runner: "node", file: "test/functional-e2e.mjs" },
-  { group: "cli-smoke", runner: "node", file: "test/import-markdown/import-markdown.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/retriever-rerank-regression.mjs" },
   { group: "core-regression", runner: "node", file: "test/smart-memory-lifecycle.mjs" },
   { group: "core-regression", runner: "node", file: "test/smart-extractor-branches.mjs" },
- (fix(import-markdown): CI測試登記 + .md目錄skip保護)
   { group: "packaging-and-workflow", runner: "node", file: "test/plugin-manifest-regression.mjs" },
   { group: "core-regression", runner: "node", file: "test/session-summary-before-reset.test.mjs", args: ["--test"] },
   { group: "packaging-and-workflow", runner: "node", file: "test/sync-plugin-version.test.mjs", args: ["--test"] },
@@ -44,13 +43,10 @@ const EXPECTED_BASELINE = [
   { group: "core-regression", runner: "node", file: "test/preference-slots.test.mjs", args: ["--test"] },
   { group: "core-regression", runner: "node", file: "test/is-latest-auto-supersede.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/temporal-awareness.test.mjs", args: ["--test"] },
-<<<<<<< HEAD
   // Issue #598 regression tests
   { group: "core-regression", runner: "node", file: "test/store-serialization.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/access-tracker-retry.test.mjs" },
   { group: "core-regression", runner: "node", file: "test/embedder-cache.test.mjs" },
-=======
->>>>>>> 1a83d72 (fix(import-markdown): CI測試登記 + .md目錄skip保護)
 ];
 
 function fail(message) {

test/import-markdown/import-markdown.test.mjs

@@ -440,7 +440,7 @@ describe("import-markdown CLI", () => {
         });
         // Should have imported the real file (1 entry from "- Real file entry")
         assert.strictEqual(imported, 1, "should import the real .md file");
-        assert.ok(skipped >= 0);
+        assert.strictEqual(skipped, 1, "should skip exactly 1 (.md directory entry)");
       } catch (err) {
         threw = true;
         throw new Error(`Import aborted on .md directory: ${err}`);