fix: register retry with Map + resetRegistration clear + test (#448)

Author: jlin53882

index.ts

@@ -1618,11 +1618,16 @@ const pluginVersion = getPluginVersion();
 // WeakSet keyed by API instance — each distinct API object tracks its own initialized state.
 // Using WeakSet instead of a module-level boolean avoids the "second register() call skips
 // hook/tool registration for the new API instance" regression that rwmjhb identified.
-const _registeredApis = new WeakSet<OpenClawPluginApi>();
+const _registeredApis = new Map<OpenClawPluginApi, boolean>();
 
 // Tracks whether register() has ever completed successfully (for retry after failure)
 let _initialized = false;
 
+// Helper for tests to check registered APIs
+export function _getRegisteredApisForTest(): Map<OpenClawPluginApi, boolean> {
+  return _registeredApis;
+}
+
 const memoryLanceDBProPlugin = {
   id: "memory-lancedb-pro",
   name: "Memory (LanceDB Pro)",
@@ -1636,7 +1641,7 @@ const memoryLanceDBProPlugin = {
       api.logger.debug?.("memory-lancedb-pro: register() called again — skipping re-init (idempotent)");
       return;
     }
-    _registeredApis.add(api);
+    // Note: Map.set is called AFTER successful init in try block
 
     try {
     // Parse and validate configuration
@@ -3852,10 +3857,12 @@ const memoryLanceDBProPlugin = {
     });
 
     // All initialization completed successfully: mark success.
+    // 只有初始化完全成功才標記為已註冊
+    _registeredApis.set(api, true);
     _initialized = true;
   } catch (err) {
-    // init 失敗：_initialized 仍為 false，下次不同 instance 可重試
-    // WeakSet 沒加入，該 instance 不會被錯誤 block
+    // init 失敗：_registeredApis 沒加入，該 api instance 可重試
+    // _initialized 仍為 false，下次不同 instance 可重試
     throw err;
   }
   },
@@ -4148,10 +4155,8 @@ export function parsePluginConfig(value: unknown): PluginConfig {
  * @public
  */
 export function resetRegistration() {
-  // Note: WeakSets cannot be cleared by design. In test scenarios where the
-  // same process reloads the module, a fresh module state means a new WeakSet.
-  // For hot-reload scenarios, the module is re-imported fresh.
-  // (WeakSet.clear() does not exist, so we do nothing here.)
+  // Clear the Map to allow re-registration after failure or hot-reload
+  _registeredApis.clear();
   _initialized = false;
 }