chore: move int to float casting outside Shell

Author: romm

src/Mapper/Tree/Builder/ScalarNodeBuilder.php

@@ -5,9 +5,11 @@
 namespace CuyZ\Valinor\Mapper\Tree\Builder;
 
 use CuyZ\Valinor\Mapper\Tree\Shell;
+use CuyZ\Valinor\Type\FloatType;
 use CuyZ\Valinor\Type\ScalarType;
 
 use function assert;
+use function is_int;
 
 /** @internal */
 final class ScalarNodeBuilder implements NodeBuilder
@@ -19,6 +21,14 @@ public function build(Shell $shell): Node
 
         assert($type instanceof ScalarType);
 
+        // When the value is an integer and the type is a float, the value is
+        // cast to float, to follow the rule of PHP regarding acceptance of an
+        // integer value in a float type. Note that PHPStan/Psalm analysis
+        // applies the same rule.
+        if ($type instanceof FloatType && is_int($value)) {
+            $value = (float)$value;
+        }
+
         if ($type->accepts($value)) {
             return $shell->node($value);
         }

src/Mapper/Tree/Shell.php

@@ -11,7 +11,6 @@
 use CuyZ\Valinor\Mapper\Tree\Exception\UnresolvableShellType;
 use CuyZ\Valinor\Mapper\Tree\Message\Message;
 use CuyZ\Valinor\Type\Dumper\TypeDumper;
-use CuyZ\Valinor\Type\FloatType;
 use CuyZ\Valinor\Type\Type;
 use CuyZ\Valinor\Type\Types\UnionType;
 use CuyZ\Valinor\Type\Types\UnresolvableType;
@@ -22,7 +21,6 @@
 use function array_map;
 use function assert;
 use function implode;
-use function is_int;
 
 /** @internal */
 final class Shell
@@ -54,9 +52,7 @@ public function __construct(
         private array $nameMap = [],
         /** @var array<string, null> */
         private array $childrenWithScalarValueCasting = [],
-    ) {
-        $this->castFloatValue();
-    }
+    ) {}
 
     public function build(): Node
     {
@@ -119,8 +115,6 @@ public function withType(Type $newType): self
         $self = clone $this;
         $self->type = $newType;
 
-        $self->castFloatValue();
-
         return $self;
     }
 
@@ -131,8 +125,6 @@ public function withValue(mixed $newValue): self
         $self->value = $newValue;
         $self->hasValue = true;
 
-        $self->castFloatValue();
-
         return $self;
     }
 
@@ -236,15 +228,4 @@ public function dumpValue(): string
     {
         return $this->hasValue ? ValueDumper::dump($this->value) : '*missing*';
     }
-
-    private function castFloatValue(): void
-    {
-        // When the value is an integer and the type is a float, the value is
-        // cast to float, to follow the rule of PHP regarding acceptance of an
-        // integer value in a float type. Note that PHPStan/Psalm analysis
-        // applies the same rule.
-        if ($this->type instanceof FloatType && is_int($this->value)) {
-            $this->value = (float)$this->value;
-        }
-    }
 }