Fix crashing if translated string is blank

Fixes #2571

Author: RocketRobz

imageview/arm9/source/language.cpp

@@ -8,6 +8,7 @@
 
 #include "common/twlmenusettings.h"
 #include "common/inifile.h"
+// #include "common/logging.h"
 
 #define STRING(what,def) std::string STR_##what;
 #include "language.inl"
@@ -18,6 +19,11 @@
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {

manual/arm9/source/language.cpp

@@ -8,6 +8,7 @@
 
 #include "common/twlmenusettings.h"
 #include "common/inifile.h"
+// #include "common/logging.h"
 
 #define STRING(what,def) std::string STR_##what;
 #include "language.inl"
@@ -18,6 +19,11 @@
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {

quickmenu/arm9/source/language.cpp

@@ -8,6 +8,7 @@
 
 #include "common/twlmenusettings.h"
 #include "common/inifile.h"
+// #include "common/logging.h"
 
 #define STRING(what,def) std::string STR_##what;
 #include "language.inl"
@@ -18,6 +19,11 @@
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {

romsel_dsimenutheme/arm9/source/language.cpp

@@ -19,6 +19,11 @@
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {

settings/arm9/source/language.cpp

@@ -21,6 +21,11 @@ extern bool useTwlCfg;
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {

title/arm9/source/language.cpp

@@ -19,6 +19,11 @@
  */
 std::string getString(CIniFile &ini, const std::string &item, const std::string &defaultValue) {
 	std::string out = ini.GetString("LANGUAGE", item, defaultValue);
+	// logPrint("%s: %s\n", item.c_str(), out.c_str());
+	if (out == "") {
+		// Fallback to default string if translated string is blank
+		out = defaultValue;
+	}
 
 	// Convert "\n" to actual newlines
 	for (uint i = 0; i < out.length() - 1; i++) {