Skip to content

Commit 42e3296

Browse files
committed
implement additional_metrics_tags in libdd-trace-stats
1 parent 799457b commit 42e3296

10 files changed

Lines changed: 1005 additions & 28 deletions

File tree

libdd-data-pipeline/src/trace_exporter/builder.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,7 @@ impl<R: SharedRuntime> TraceExporterBuilder<R> {
750750
span_kinds,
751751
self.peer_tags.clone(),
752752
None,
753+
vec![],
753754
#[cfg(feature = "stats-obfuscation")]
754755
None,
755756
)));

libdd-data-pipeline/src/trace_exporter/stats.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ pub(crate) fn start_stats_computation<
143143
span_kinds,
144144
peer_tags,
145145
ctx.stats_cardinality_limit,
146+
vec![],
146147
#[cfg(feature = "stats-obfuscation")]
147148
Some(client_side_stats.obfuscation_config.clone()),
148149
)));

libdd-trace-protobuf/src/pb_test.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ mod tests {
7272
],
7373
"HTTPMethod": "GET",
7474
"HTTPEndpoint": "/test",
75-
"GRPCStatusCode": "0"
75+
"GRPCStatusCode": "0",
76+
"AdditionalMetricTags": []
7677
}
7778
]
7879
}

libdd-trace-stats/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ let mut concentrator = SpanConcentrator::new(
7676
SystemTime::now(),
7777
vec!["client".to_string(), "server".to_string()], // eligible span kinds
7878
vec!["peer.service".to_string()], // peer tag keys
79+
vec!["example.key".to_string()], // additional metric tag keys
7980
);
8081

8182
// Add spans

libdd-trace-stats/benches/span_concentrator_bench.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
4545
vec![],
4646
vec!["db_name".into(), "bucket_s3".into()],
4747
None,
48+
vec![],
4849
#[cfg(feature = "stats-obfuscation")]
4950
None,
5051
);

0 commit comments

Comments
 (0)