Skip to content

Commit 78b0b02

Browse files
committed
fix: workflows and readme caveat
1 parent 1894020 commit 78b0b02

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/publish-nuget.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
dotnet pack DistributedRateLimiter.Core/DistributedRateLimiter.Core.csproj $PACK_ARGS
108108
dotnet pack DistributedRateLimiter/DistributedRateLimiter.csproj $PACK_ARGS
109109
dotnet pack DistributedRateLimiter.Providers.MsSql/DistributedRateLimiter.Providers.MsSql.csproj $PACK_ARGS
110-
dotnet pack DbRateLimiter.Providers.MySql/DbRateLimiter.Providers.MySql.csproj $PACK_ARGS
110+
dotnet pack DistributedRateLimiter.Providers.MySql/DistributedRateLimiter.Providers.MySql.csproj $PACK_ARGS
111111
dotnet pack DistributedRateLimiter.Providers.Postgres/DistributedRateLimiter.Providers.Postgres.csproj $PACK_ARGS
112112
113113
- name: Validate packages
@@ -119,7 +119,7 @@ jobs:
119119
"DistributedRateLimiter.Core"
120120
"DistributedRateLimiter"
121121
"DistributedRateLimiter.Providers.MsSql"
122-
"DbRateLimiter.Providers.MySql"
122+
"DistributedRateLimiter.Providers.MySql"
123123
"DistributedRateLimiter.Providers.Postgres"
124124
)
125125
@@ -172,7 +172,7 @@ jobs:
172172
echo "### 📦 Published Packages" >> $GITHUB_STEP_SUMMARY
173173
echo "| Package | NuGet |" >> $GITHUB_STEP_SUMMARY
174174
echo "|---------|-------|" >> $GITHUB_STEP_SUMMARY
175-
for pkg in DistributedRateLimiter.Core DistributedRateLimiter DistributedRateLimiter.Providers.MsSql DbRateLimiter.Providers.MySql DistributedRateLimiter.Providers.Postgres; do
175+
for pkg in DistributedRateLimiter.Core DistributedRateLimiter DistributedRateLimiter.Providers.MsSql DistributedRateLimiter.Providers.MySql DistributedRateLimiter.Providers.Postgres; do
176176
echo "| \`${pkg}\` | [${pkg} v${VERSION}](https://www.nuget.org/packages/${pkg}/${VERSION}) |" >> $GITHUB_STEP_SUMMARY
177177
done
178178
echo "" >> $GITHUB_STEP_SUMMARY
@@ -208,7 +208,7 @@ jobs:
208208
run: |
209209
VERSION="${{ steps.extract_version.outputs.version }}"
210210
echo "🎉 Successfully published DistributedRateLimiter v${VERSION} to NuGet!"
211-
for pkg in DistributedRateLimiter.Core DistributedRateLimiter DistributedRateLimiter.Providers.MsSql DbRateLimiter.Providers.MySql DistributedRateLimiter.Providers.Postgres; do
211+
for pkg in DistributedRateLimiter.Core DistributedRateLimiter DistributedRateLimiter.Providers.MsSql DistributedRateLimiter.Providers.MySql DistributedRateLimiter.Providers.Postgres; do
212212
echo "📦 https://www.nuget.org/packages/${pkg}/${VERSION}"
213213
done
214214
if [ "${{ github.event_name }}" == "release" ]; then

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,8 @@ CREATE TABLE IF NOT EXISTS __rate_limits (
335335

336336
All three algorithms use a single atomic round-trip via `INSERT ... ON CONFLICT DO UPDATE ... RETURNING`.
337337

338+
**Minimum version:** PostgreSQL 9.5+ (required for `ON CONFLICT DO UPDATE`). PostgreSQL 12+ recommended.
339+
338340
**Package:** `Npgsql` 8.x+. Targets `net8.0`, `net9.0`, `net10.0`.
339341

340342
---
@@ -388,7 +390,9 @@ CREATE TABLE IF NOT EXISTS `__rate_limits` (
388390
);
389391
```
390392

391-
> MySQL/MariaDB does not support `RETURNING` on upserts so each check costs 2 round-trips instead of 1.
393+
> MySQL/MariaDB does not support `RETURNING` on upserts so each check costs 2 round-trips instead of 1. Each check is wrapped in a transaction with `SELECT ... FOR UPDATE` to guarantee atomicity — this requires InnoDB (the default engine since MySQL 5.5).
394+
395+
**Minimum version:** MySQL 5.7+ or MariaDB 10.2+. `DATETIME(6)` microsecond precision requires MySQL 5.6+ / MariaDB 5.3+.
392396

393397
**Package:** `MySqlConnector` 2.x. Targets `net8.0`, `net9.0`, `net10.0`.
394398

0 commit comments

Comments
 (0)