Revert "Disable Failing Windows tests"

This reverts commit a5b43ea.

Author: igordmn

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ComposeSceneTest.kt

@@ -105,7 +105,6 @@ import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.withContext
 import org.jetbrains.skia.Surface
 import org.junit.Assert.assertFalse
-import org.junit.Assume.assumeTrue
 import org.junit.Ignore
 import org.junit.Rule
 import org.junit.Test
@@ -839,9 +838,6 @@ class ComposeSceneTest {
 
     @Test
     fun sendApplyNotificationsFromNonUiThreadDoesntDeadlock() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         // https://youtrack.jetbrains.com/issue/CMP-7838
         var value by mutableStateOf(0)
         val derivedValue by derivedStateOf {

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeDialogTest.kt

@@ -33,7 +33,6 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.input.pointer.PointerEventType
 import androidx.compose.ui.input.pointer.pointerInput
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.layout
 import androidx.compose.ui.sendMouseEvent
 import androidx.compose.ui.sendMousePress
@@ -62,7 +61,6 @@ import org.jetbrains.skiko.MainUIDispatcher
 import org.jetbrains.skiko.OS
 import org.jetbrains.skiko.SkiaLayerAnalytics
 import org.junit.Assume
-import org.junit.Assume.assumeTrue
 import org.junit.Rule
 import org.junit.Test
 import org.junit.rules.Timeout
@@ -375,9 +373,6 @@ class ComposeDialogTest {
 
     @Test
     fun `ComposeDialog with popup prefSize`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         val dialog = ComposeDialog().apply {
             setContent {
                 Box(Modifier.size(100.dp))

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposePanelTest.kt

@@ -52,7 +52,6 @@ import androidx.compose.ui.input.key.KeyEvent
 import androidx.compose.ui.input.key.onKeyEvent
 import androidx.compose.ui.input.pointer.PointerEventType
 import androidx.compose.ui.input.pointer.onPointerEvent
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.onGloballyPositioned
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.sendCharTypedEvents
@@ -100,7 +99,6 @@ import org.jetbrains.skiko.MainUIDispatcher
 import org.jetbrains.skiko.OS
 import org.jetbrains.skiko.SkiaLayerAnalytics
 import org.junit.Assume.assumeFalse
-import org.junit.Assume.assumeTrue
 import org.junit.Rule
 import org.junit.Test
 import org.junit.rules.Timeout
@@ -913,9 +911,6 @@ class ComposePanelTest {
 
     @Test
     fun `ComposePanel draws background correctly`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         // Show a canvas and a `ComposePanel` with the same background and compare the two colors.
         // Simply comparing to the set color doesn't work because Robot returns the color after
         // the OS transforms it to the screen color space (which doesn't seem accessible from

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/SwingPanelTest.kt

@@ -30,7 +30,6 @@ import androidx.compose.runtime.mutableFloatStateOf
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.LayoutBoundsHolder
 import androidx.compose.ui.layout.layoutBounds
 import androidx.compose.ui.platform.LocalDensity
@@ -61,7 +60,6 @@ import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertIs
 import kotlin.test.assertTrue
-import org.junit.Assume.assumeTrue
 
 class SwingPanelTest {
     /**
@@ -221,9 +219,6 @@ class SwingPanelTest {
 
     @Test
     fun swingPanelRespondsToDensityChange() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         val swingComponent = object: JComponent() {
             override fun paint(g: Graphics) {
                 g.color = java.awt.Color.RED

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/ApplicationTest.kt

@@ -33,7 +33,6 @@ import androidx.compose.ui.geometry.Offset
 import androidx.compose.ui.geometry.isSpecified
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.isLinux
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.onGloballyPositioned
 import androidx.compose.ui.layout.onPlaced
 import androidx.compose.ui.layout.positionOnScreen
@@ -268,9 +267,6 @@ class ApplicationTest {
 
     @Test
     fun `onGloballyPositioned is not called repeatedly with same position on screen`() = runApplicationTest(useDelay = true) {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         lateinit var window: ComposeWindow
         val positionsOnScreen = mutableListOf<Offset>()
         launchTestApplication {

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/DesktopPopupTest.kt

@@ -39,7 +39,6 @@ import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.input.key.Key
 import androidx.compose.ui.input.key.KeyEvent
 import androidx.compose.ui.input.key.KeyEventType
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.Layout
 import androidx.compose.ui.layout.LayoutCoordinates
 import androidx.compose.ui.layout.onGloballyPositioned
@@ -63,7 +62,6 @@ import javax.swing.JFrame
 import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
 import kotlin.test.assertTrue
-import org.junit.Assume.assumeTrue
 import org.junit.Rule
 import org.junit.Test
 
@@ -386,14 +384,10 @@ class DesktopPopupTest {
         }
 
     @Test
-    fun popup_reportsCorrectPositionInWindow_onWindowLayerType() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
+    fun popup_reportsCorrectPositionInWindow_onWindowLayerType() =
         ComposeFeatureFlags.layerType.withOverride(LayerType.OnWindow) {
             popup_reportsCorrectPositionInWindow()
         }
-    }
 
     private fun popup_reportsCorrectPositionInWindow() = runApplicationTest {
         val popupOffset = IntOffset(40, 70)

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/DialogWindowTest.kt

@@ -43,7 +43,6 @@ import androidx.compose.ui.input.key.Key
 import androidx.compose.ui.input.key.key
 import androidx.compose.ui.input.key.onKeyEvent
 import androidx.compose.ui.input.key.onPreviewKeyEvent
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.platform.LocalLayoutDirection
 import androidx.compose.ui.sendKeyEvent
 import androidx.compose.ui.test.ExperimentalTestApi
@@ -72,7 +71,6 @@ import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
 import kotlin.time.Duration.Companion.seconds
 import kotlinx.coroutines.delay
-import org.junit.Assume.assumeTrue
 
 class DialogWindowTest {
     @Test
@@ -586,9 +584,6 @@ class DialogWindowTest {
 
     @Test(timeout = 30000)
     fun `should draw before dialog is visible`() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         val windowSize = DpSize(400.dp, 300.dp)
         testDrawingBeforeDialogIsVisible(
             dialogState = DialogState(size = windowSize),
@@ -729,9 +724,6 @@ class DialogWindowTest {
 
     @Test
     fun `dialog does not flash background when closed`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         lateinit var window: Window
         lateinit var dialog: Dialog
         var showDialog by mutableStateOf(false)

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/WindowTest.kt

@@ -41,7 +41,6 @@ import androidx.compose.ui.awt.SwingWindow
 import androidx.compose.ui.background
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.isLinux
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.Layout
 import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.platform.LocalLayoutDirection
@@ -79,7 +78,6 @@ import kotlinx.coroutines.plus
 import kotlinx.coroutines.runBlocking
 import org.jetbrains.skiko.MainUIDispatcher
 import org.junit.Assume.assumeFalse
-import org.junit.Assume.assumeTrue
 import org.junit.Ignore
 
 class WindowTest {
@@ -507,9 +505,6 @@ class WindowTest {
 
     @Test(timeout = 30000)
     fun `should draw before window is visible`() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         val windowSize = DpSize(400.dp, 300.dp)
         testDrawingBeforeWindowIsVisible(
             windowState = WindowState(size = windowSize),
@@ -633,9 +628,6 @@ class WindowTest {
 
     @Test
     fun `showing a window should measure content specified size`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         // TODO fix on Linux https://github.com/JetBrains/compose-multiplatform/issues/1297
         assumeFalse(isLinux)
         val constraintsList = mutableListOf<Constraints>()
@@ -796,9 +788,6 @@ class WindowTest {
 
     @Test
     fun `window does not flash background when closed`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         lateinit var outerWindow: Window
         lateinit var innerWindow: Window
         var showInnerWindow by mutableStateOf(false)

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/WindowTypingLocationTest.kt

@@ -17,10 +17,8 @@
 package androidx.compose.ui.window
 
 import androidx.compose.ui.focusedInputMethodRequests
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.sendCharTypedEvents
 import java.awt.Rectangle
-import org.junit.Assume.assumeTrue
 import org.junit.experimental.theories.Theories
 import org.junit.experimental.theories.Theory
 import org.junit.runner.RunWith
@@ -34,12 +32,6 @@ class WindowTypingLocationTest: BaseWindowTextFieldTest() {
         textFieldKind = textFieldKind,
         name = "input methods text location going right when typing"
     ) {
-        // TODO Fix failing
-        if (isWindows) {
-            println("Skipped")
-            return@runTextFieldTest
-        }
-
         val location0 = window.focusedInputMethodRequests()!!.getTextLocation(null)
 
         window.sendCharTypedEvents('a')

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/v2/DialogWindowV2StateTest.kt

@@ -32,7 +32,6 @@ import androidx.compose.ui.awt.ComposeDialog
 import androidx.compose.ui.awt.ComposeWindow
 import androidx.compose.ui.isLinux
 import androidx.compose.ui.isMacOs
-import androidx.compose.ui.isWindows
 import androidx.compose.ui.layout.Layout
 import androidx.compose.ui.toDpSize
 import androidx.compose.ui.unit.DpOffset
@@ -382,9 +381,6 @@ class DialogWindowV2StateTest {
 
     @Test
     fun `set dialog preferred height`() = runApplicationTest(useDelay = isLinux) {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         assumeTrue(!isLinux)  // Flaky on our CI
 
         lateinit var dialog: ComposeDialog
@@ -418,9 +414,6 @@ class DialogWindowV2StateTest {
 
     @Test
     fun `set dialog preferred width`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         assumeTrue(!isLinux)  // Flaky on our CI
 
         lateinit var dialog: ComposeDialog
@@ -453,9 +446,6 @@ class DialogWindowV2StateTest {
 
     @Test
     fun `set unconstrained dialog size by its content`() = runApplicationTest {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
         assumeTrue(!isLinux) // Flaky on our CI
 
         lateinit var dialog: ComposeDialog
@@ -811,56 +801,41 @@ class DialogWindowV2StateTest {
     }
 
     @Test
-    fun dialogPreferredWidth() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
-        runDialogSizeTest(
-            testName = "dialogPreferredWidth",
-            sizeProvider = WindowSizeProvider.PreferredWidth(height = 500.dp),
-            content = {
-                BoxWithGivenSize(
-                    width = { 400.dp.roundToPx() }
-                )
-            },
-            expectedDialogSizeSansInsets = DpSize(400.dp, 500.dp)
-        )
-    }
+    fun dialogPreferredWidth() = runDialogSizeTest(
+        testName = "dialogPreferredWidth",
+        sizeProvider = WindowSizeProvider.PreferredWidth(height = 500.dp),
+        content = {
+            BoxWithGivenSize(
+                width = { 400.dp.roundToPx() }
+            )
+        },
+        expectedDialogSizeSansInsets = DpSize(400.dp, 500.dp)
+    )
 
     @Test
-    fun dialogPreferredHeight() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
-        runDialogSizeTest(
-            testName = "dialogPreferredHeight",
-            sizeProvider = WindowSizeProvider.PreferredHeight(width = 500.dp),
-            content = {
-                BoxWithGivenSize(
-                    height = { 400.dp.roundToPx() }
-                )
-            },
-            expectedDialogSizeSansInsets = DpSize(500.dp, 400.dp)
-        )
-    }
+    fun dialogPreferredHeight() = runDialogSizeTest(
+        testName = "dialogPreferredHeight",
+        sizeProvider = WindowSizeProvider.PreferredHeight(width = 500.dp),
+        content = {
+            BoxWithGivenSize(
+                height = { 400.dp.roundToPx() }
+            )
+        },
+        expectedDialogSizeSansInsets = DpSize(500.dp, 400.dp)
+    )
 
     @Test
-    fun `preferred size is rounded up`() {
-        // TODO Fix failing
-        assumeTrue(!isWindows)
-
-        runDialogSizeTest(
-            testName = "preferred size is rounded up",
-            sizeProvider = WindowSizeProvider.Unconstrained,
-            content = {
-                Layout { _, _ ->
-                    val size = (density * 100 + 1).toInt()
-                    layout(size, size) { }
-                }
-            },
-            expectedDialogSizeSansInsets = DpSize(101.dp, 101.dp)
-        )
-    }
+    fun `preferred size is rounded up`() = runDialogSizeTest(
+        testName = "preferred size is rounded up",
+        sizeProvider = WindowSizeProvider.Unconstrained,
+        content = {
+            Layout { _, _ ->
+                val size = (density * 100 + 1).toInt()
+                layout(size, size) { }
+            }
+        },
+        expectedDialogSizeSansInsets = DpSize(101.dp, 101.dp)
+    )
 
     private fun runBoundsOverwriteTest(
         name: String,