Skip to content

Commit 025ac89

Browse files
etzel-meslhein
authored andcommitted
fix(sonar): use nullish assignment
1 parent acaa3d0 commit 025ac89

5 files changed

Lines changed: 5 additions & 15 deletions

File tree

packages/ui/src/models/visualization/metadata/beans-entity-handler.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ export class BeansEntityHandler {
7070
}
7171

7272
let entity = this.getBeansEntity();
73-
if (!entity) {
74-
entity = this.createBeansEntity();
75-
}
73+
entity ??= this.createBeansEntity();
7674
if (entity) {
7775
entity.parent.beans = model;
7876
}

packages/ui/src/pages/PipeErrorHandler/PipeErrorHandlerPage.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ export const PipeErrorHandlerPage: FunctionComponent = () => {
3737
(model: Record<string, unknown>) => {
3838
if (Object.keys(model).length > 0) {
3939
let entity = pipeResource.getErrorHandlerEntity();
40-
if (!entity) {
41-
entity = pipeResource.createErrorHandlerEntity();
42-
}
40+
entity ??= pipeResource.createErrorHandlerEntity();
4341
entity.parent.errorHandler = model;
4442
} else {
4543
pipeResource!.deleteErrorHandlerEntity();

packages/ui/src/utils/event-notifier.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ export class EventNotifier extends EventTarget {
77
private static instance: EventNotifier | undefined;
88

99
static getInstance(): EventNotifier {
10-
if (!this.instance) {
11-
this.instance = new EventNotifier();
12-
}
10+
this.instance ??= new EventNotifier();
1311

1412
return this.instance;
1513
}

packages/ui/src/xml-schema-ts/extensions/DefaultExtensionDeserializer.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ export class DefaultExtensionDeserializer implements ExtensionDeserializer {
2323
// elements or the attributes
2424

2525
let metaInfoMap = schemaObject.getMetaInfoMap();
26-
if (metaInfoMap == null) {
27-
metaInfoMap = new Map<string, object>();
28-
}
26+
metaInfoMap ??= new Map<string, object>();
2927

3028
if (node.nodeType == Node.ATTRIBUTE_NODE) {
3129
let attribMap: Map<QName, Node>;

packages/ui/src/xml-schema-ts/utils/NodeNamespaceContext.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ export class NodeNamespaceContext implements NamespacePrefixList {
1616
}
1717

1818
getDeclaredPrefixes(): string[] {
19-
if (this.prefixes === undefined) {
20-
this.prefixes = Object.keys(this.declarations);
21-
}
19+
this.prefixes ??= Object.keys(this.declarations);
2220
return this.prefixes;
2321
}
2422

0 commit comments

Comments
 (0)