refactor: replace boost::ignore_unused with attribute

Author: KazDragon

include/telnetpp/options/mccp/codec.hpp

@@ -2,8 +2,9 @@
 
 #include "telnetpp/core.hpp"
 
-#include <boost/exception/all.hpp>
+#include <boost/exception/exception.hpp>
 
+#include <functional>
 #include <stdexcept>
 
 namespace telnetpp::options::mccp {
@@ -49,12 +50,12 @@ class TELNETPP_EXPORT codec
     //* =====================================================================
     /// \brief A hook for when the transformation stream starts.
     //* =====================================================================
-    virtual void do_start(){};
+    virtual void do_start() {};
 
     //* =====================================================================
     /// \brief A hook for when transformation stream ends.
     //* =====================================================================
-    virtual void do_finish(continuation const & /*cont*/){};
+    virtual void do_finish(continuation const & /*cont*/) {};
 
     //* =====================================================================
     /// \brief Transform the given bytes, sending the transformed data

include/telnetpp/options/naws/client.hpp

@@ -20,7 +20,7 @@ class TELNETPP_EXPORT client : public telnetpp::client_option
     explicit client(telnetpp::session &sess) noexcept;
 
     boost::signals2::signal<void(window_dimension, window_dimension)>
-        on_window_size_changed;
+        on_window_size_changed;  // NOLINT
 
 private:
     //* =====================================================================

include/telnetpp/options/terminal_type/client.hpp

@@ -23,7 +23,7 @@ class TELNETPP_EXPORT client : public telnetpp::client_option
     //* =====================================================================
     void request_terminal_type();
 
-    boost::signals2::signal<void(telnetpp::bytes)> on_terminal_type;
+    boost::signals2::signal<void(telnetpp::bytes)> on_terminal_type;  // NOLINT
 
 private:
     //* =====================================================================

src/options/mccp/zlib/compressor.cpp

@@ -1,6 +1,5 @@
 #include "telnetpp/options/mccp/zlib/compressor.hpp"
 
-#include <boost/core/ignore_unused.hpp>
 #include <zlib.h>
 
 #include <optional>
@@ -36,8 +35,8 @@ struct compressor::impl
 
         stream_ = z_stream{};
 
-        auto result = deflateInit(&*stream_, Z_DEFAULT_COMPRESSION);
-        boost::ignore_unused(result);
+        [[maybe_unused]] auto result =
+            deflateInit(&*stream_, Z_DEFAULT_COMPRESSION);
         assert(result == Z_OK);
     }
 
@@ -48,8 +47,7 @@ struct compressor::impl
     {
         assert(stream_ != std::nullopt);
 
-        auto result = deflateEnd(&*stream_);
-        boost::ignore_unused(result);
+        [[maybe_unused]] auto result = deflateEnd(&*stream_);
         assert(result == Z_OK || result == Z_STREAM_ERROR || Z_DATA_ERROR);
 
         stream_ = std::nullopt;
@@ -134,8 +132,7 @@ telnetpp::bytes compressor::transform_chunk(
     pimpl_->stream_->avail_out = output_buffer_size;
     pimpl_->stream_->next_out = output_buffer;
 
-    auto response = deflate(&*pimpl_->stream_, Z_SYNC_FLUSH);
-    boost::ignore_unused(response);
+    [[maybe_unused]] auto response = deflate(&*pimpl_->stream_, Z_SYNC_FLUSH);
     assert(response == Z_OK);
 
     auto const output_data =

src/options/mccp/zlib/decompressor.cpp

@@ -1,6 +1,5 @@
 #include "telnetpp/options/mccp/zlib/decompressor.hpp"
 
-#include <boost/core/ignore_unused.hpp>
 #include <zlib.h>
 
 #include <optional>
@@ -36,8 +35,7 @@ struct decompressor::impl
 
         stream_ = z_stream{};
 
-        auto result = inflateInit(&*stream_);
-        boost::ignore_unused(result);
+        [[maybe_unused]] auto result = inflateInit(&*stream_);
         assert(result == Z_OK);
     }
 
@@ -48,8 +46,7 @@ struct decompressor::impl
     {
         assert(stream_ != std::nullopt);
 
-        auto result = inflateEnd(&*stream_);
-        boost::ignore_unused(result);
+        [[maybe_unused]] auto result = inflateEnd(&*stream_);
         assert(result == Z_OK || result == Z_STREAM_ERROR);
 
         stream_ = std::nullopt;