Fix store_date and foc_date range filters not applying in issue list view (#547)

The IssueViewFilter declared date range filters as `store_date_range` and `foc_date_range`, but DateFromToRangeFilter generates GET params named `{field_name}_after` / `{field_name}_before`. The template was sending `store_date_after` / `store_date_before`, so the params never matched and the filter was silently ignored. Renamed the fields to `store_date` and `foc_date` to align with the template, and added regression tests covering after/before/same-date scenarios for both fields.

Author: bpepple

comicsdb/filters/issue.py

@@ -132,8 +132,8 @@ class IssueViewFilter(df.FilterSet):
     series_type = df.NumberFilter(
         label="Series Type", field_name="series__series_type__id", lookup_expr="exact"
     )
-    store_date_range = df.DateFromToRangeFilter("store_date")
-    foc_date_range = df.DateFromToRangeFilter("foc_date")
+    store_date = df.DateFromToRangeFilter("store_date")
+    foc_date = df.DateFromToRangeFilter("foc_date")
     series_year_began = df.NumberFilter(
         label="Series Beginning Year", field_name="series__year_began", lookup_expr="exact"
     )
@@ -148,4 +148,4 @@ class IssueViewFilter(df.FilterSet):
 
     class Meta:
         model = Issue
-        fields = ["q", "store_date", "foc_date"]
+        fields = ["q"]

tests/comicsdb/test_issue_views.py

@@ -1855,3 +1855,223 @@ def test_issue_list_has_active_filters_indicator(
     resp = client.get(reverse("issue:list") + "?page=1")
     assert resp.status_code == HTML_OK_CODE
     assert resp.context["has_active_filters"] is False
+
+
+def test_issue_filter_by_store_date_after(
+    auto_login_user, create_user, dc_comics, single_issue_type
+):
+    """Test store_date_after filter returns issues on or after the given date."""
+    client, user = auto_login_user()
+
+    series = Series.objects.create(
+        name="Batman",
+        publisher=dc_comics,
+        series_type=single_issue_type,
+        year_began=2026,
+        status=Series.Status.ONGOING,
+        volume=1,
+        created_by=user,
+        edited_by=user,
+    )
+
+    early_issue = Issue.objects.create(
+        series=series,
+        number="1",
+        cover_date=date(2026, 6, 1),
+        store_date=date(2026, 6, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    later_issue = Issue.objects.create(
+        series=series,
+        number="2",
+        cover_date=date(2026, 7, 1),
+        store_date=date(2026, 7, 1),
+        created_by=user,
+        edited_by=user,
+    )
+
+    resp = client.get(reverse("issue:list") + "?store_date_after=2026-07-01")
+    assert resp.status_code == HTML_OK_CODE
+    assert later_issue in resp.context["issue_list"]
+    assert early_issue not in resp.context["issue_list"]
+    assert resp.context["issue_list"].count() == 1
+
+
+def test_issue_filter_by_store_date_before(
+    auto_login_user, create_user, dc_comics, single_issue_type
+):
+    """Test store_date_before filter returns issues on or before the given date."""
+    client, user = auto_login_user()
+
+    series = Series.objects.create(
+        name="Batman",
+        publisher=dc_comics,
+        series_type=single_issue_type,
+        year_began=2026,
+        status=Series.Status.ONGOING,
+        volume=1,
+        created_by=user,
+        edited_by=user,
+    )
+
+    early_issue = Issue.objects.create(
+        series=series,
+        number="1",
+        cover_date=date(2026, 6, 1),
+        store_date=date(2026, 6, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    Issue.objects.create(
+        series=series,
+        number="2",
+        cover_date=date(2026, 8, 1),
+        store_date=date(2026, 8, 1),
+        created_by=user,
+        edited_by=user,
+    )
+
+    resp = client.get(reverse("issue:list") + "?store_date_before=2026-07-01")
+    assert resp.status_code == HTML_OK_CODE
+    assert early_issue in resp.context["issue_list"]
+    assert resp.context["issue_list"].count() == 1
+
+
+def test_issue_filter_by_store_date_range_same_date(
+    auto_login_user, create_user, dc_comics, single_issue_type
+):
+    """Test store_date_after and store_date_before with the same date returns only exact matches."""
+    client, user = auto_login_user()
+
+    series = Series.objects.create(
+        name="Batman",
+        publisher=dc_comics,
+        series_type=single_issue_type,
+        year_began=2026,
+        status=Series.Status.ONGOING,
+        volume=1,
+        created_by=user,
+        edited_by=user,
+    )
+
+    target_issue = Issue.objects.create(
+        series=series,
+        number="1",
+        cover_date=date(2026, 7, 1),
+        store_date=date(2026, 7, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    Issue.objects.create(
+        series=series,
+        number="2",
+        cover_date=date(2026, 6, 1),
+        store_date=date(2026, 6, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    Issue.objects.create(
+        series=series,
+        number="3",
+        cover_date=date(2026, 8, 1),
+        store_date=date(2026, 8, 1),
+        created_by=user,
+        edited_by=user,
+    )
+
+    resp = client.get(
+        reverse("issue:list") + "?store_date_after=2026-07-01&store_date_before=2026-07-01"
+    )
+    assert resp.status_code == HTML_OK_CODE
+    assert target_issue in resp.context["issue_list"]
+    assert resp.context["issue_list"].count() == 1
+
+
+def test_issue_filter_by_foc_date_after(auto_login_user, create_user, dc_comics, single_issue_type):
+    """Test foc_date_after filter returns issues with FOC date on or after the given date."""
+    client, user = auto_login_user()
+
+    series = Series.objects.create(
+        name="Batman",
+        publisher=dc_comics,
+        series_type=single_issue_type,
+        year_began=2026,
+        status=Series.Status.ONGOING,
+        volume=1,
+        created_by=user,
+        edited_by=user,
+    )
+
+    early_issue = Issue.objects.create(
+        series=series,
+        number="1",
+        cover_date=date(2026, 6, 1),
+        foc_date=date(2026, 5, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    later_issue = Issue.objects.create(
+        series=series,
+        number="2",
+        cover_date=date(2026, 8, 1),
+        foc_date=date(2026, 7, 1),
+        created_by=user,
+        edited_by=user,
+    )
+
+    resp = client.get(reverse("issue:list") + "?foc_date_after=2026-07-01")
+    assert resp.status_code == HTML_OK_CODE
+    assert later_issue in resp.context["issue_list"]
+    assert early_issue not in resp.context["issue_list"]
+    assert resp.context["issue_list"].count() == 1
+
+
+def test_issue_filter_by_foc_date_range_same_date(
+    auto_login_user, create_user, dc_comics, single_issue_type
+):
+    """Test foc_date_after and foc_date_before with the same date returns only exact matches."""
+    client, user = auto_login_user()
+
+    series = Series.objects.create(
+        name="Batman",
+        publisher=dc_comics,
+        series_type=single_issue_type,
+        year_began=2026,
+        status=Series.Status.ONGOING,
+        volume=1,
+        created_by=user,
+        edited_by=user,
+    )
+
+    target_issue = Issue.objects.create(
+        series=series,
+        number="1",
+        cover_date=date(2026, 7, 1),
+        foc_date=date(2026, 7, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    Issue.objects.create(
+        series=series,
+        number="2",
+        cover_date=date(2026, 6, 1),
+        foc_date=date(2026, 6, 1),
+        created_by=user,
+        edited_by=user,
+    )
+    Issue.objects.create(
+        series=series,
+        number="3",
+        cover_date=date(2026, 8, 1),
+        foc_date=date(2026, 8, 1),
+        created_by=user,
+        edited_by=user,
+    )
+
+    resp = client.get(
+        reverse("issue:list") + "?foc_date_after=2026-07-01&foc_date_before=2026-07-01"
+    )
+    assert resp.status_code == HTML_OK_CODE
+    assert target_issue in resp.context["issue_list"]
+    assert resp.context["issue_list"].count() == 1