bit_lib Library Extension

[Lemn4t]

Description of the feature you're suggesting.

At the moment, the bit_lib library only has the bit_lib_set_bits function, and it would be nice to have the bit_lib_set_bits_16/32/64 functions available for setting values, similar to getting values by position using get.

Anything else?

No response

[WillyJL]

Doesn't bit_lib_set_bits() suffice, considering it takes a length argument and a glance at the code seems like it could handle up to (I'm assuming) 64 bits?

[Lemn4t]

Doesn't bit_lib_set_bits() suffice, considering it takes a length argument and a glance at the code seems like it could handle up to (I'm assuming) 64 bits?

Yes, that's right, I've tested these features, and they work.

void bit_lib_set_bits_16(uint8_t* data, size_t position, uint16_t byte, uint8_t length) {
    furi_check(length <= 16);
    furi_check(length > 0);

    for(uint8_t i = 0; i < length; ++i) {
        uint8_t shift = (length - 1) - i;
        bit_lib_set_bit(data, position + i, (byte >> shift) & 1); //-V610
    }
}

void bit_lib_set_bits_32(uint8_t* data, size_t position, uint32_t byte, uint8_t length) {
    furi_check(length <= 32);
    furi_check(length > 0);

    for(uint8_t i = 0; i < length; ++i) {
        uint8_t shift = (length - 1) - i;
        bit_lib_set_bit(data, position + i, (byte >> shift) & 1); //-V610
    }
}

[WillyJL]

ah, i had not noticed the furi_check(length <= 8) in bit_lib_set_bits()

[WillyJL]

this suggestion would be more fit for official firmware repository i think, you can open a PR there since you already have the code (though im not sure if it will work, i feel like they limited it to 8 bits for a reason, and the get bits functions do different things depending on the length specified, the set bits function probably needs to do something similar)