fix: removed usda:usdt pair (#96)

Author: onikonychev

README.md

@@ -18,7 +18,6 @@ The `pricefeeder` is a tool developed for Nibiru's [Oracle Module consensus](htt
 - [Chainlink on B^2 Network](#chainlink-on-b2-network)
 - [Eris Protocol for stNIBI price](#eris-protocol-for-stnibi-price)
   - [Eris Protocol for stNIBI price](#eris-protocol-for-stnibi-price-1)
-  - [Avalon Finance for sUSDa, USDa](#avalon-finance-for-susda-usda)
 - [Glossary](#glossary)
 
 ## Quick Start - Local Development
@@ -188,14 +187,6 @@ ERIS_PROTOCOL_CONTRACT_ADDRESS="nibi1udqqx30cw8nwjxtl4l28ym9hhrp933zlq8dqxfjzcdh
 ERIS_PROTOCOL_CONTRACT_ADDRESS="nibi1keqw4dllsczlldd7pmzp25wyl04fw5anh3wxljhg4fjuqj9xnxuqa82rpg"
 ```
 
-### Avalon Finance for sUSDa, USDa
-
-
-[Avalon Finance](https://avalonfinance.xyz) is a CeDeFi lending project that
-powers both USDa and sUSDa. The redeem rate between USDa and its yield-bearing variant, sUSDa, is retrieved from the API provided by Avalon Labs. 
-
-This data source adds queries for the "susda:usda" and "susda:usd" asset pairs.
-
 ### Chainlink on B^2 Network
 
 Some token prices are retrieved from other chains Chainlink oracles.

config/config.go

@@ -75,10 +75,6 @@ var defaultExchangeSymbolsMap = map[string]map[asset.Pair]types.Symbol{
 		"ustnibi:unibi": "ustnibi:unibi", // this is the only pair supported by the Eris Protocol smart contract
 	},
 
-	sources.SourceNameUniswapV3: {
-		"usda:usd": "USDa:USDT",
-	},
-
 	sources.SourceNameChainLink: {
 		"b2btc:btc": "uBTC/BTC",
 	},

feeder/priceprovider.go

@@ -251,40 +251,6 @@ func (a AggregatePriceProvider) GetPrice(pair asset.Pair) types.Price {
 			}
 		}
 
-	case "susda:usd":
-		priceSusdaUsda := a.GetPrice("susda:usda")
-		if !priceSusdaUsda.Valid || priceSusdaUsda.Price <= 0 {
-			// if we can't find a valid susda:usda price, return an invalid price
-			a.logger.Warn().Str("pair", pairStr).Msg("no valid price found")
-			aggregatePriceProvider.WithLabelValues(pairStr, "missing", "false").Inc()
-			return types.Price{
-				SourceName: "missing",
-				Pair:       pair,
-				Price:      types.PriceAbstain,
-				Valid:      false,
-			}
-		}
-
-		priceUsdaUsd := a.GetPrice("usda:usd")
-		if priceUsdaUsd.Valid && priceUsdaUsd.Price > 0 {
-			return types.Price{
-				Pair:       pair,
-				Price:      priceSusdaUsda.Price * priceUsdaUsd.Price,
-				SourceName: priceSusdaUsda.SourceName,
-				Valid:      true,
-			}
-		}
-
-		// if either price is invalid, return an invalid price
-		a.logger.Warn().Str("pair", pairStr).Msg("no valid price found")
-		aggregatePriceProvider.WithLabelValues(pairStr, "missing", "false").Inc()
-		return types.Price{
-			SourceName: "missing",
-			Pair:       pair,
-			Price:      types.PriceAbstain,
-			Valid:      false,
-		}
-
 	default:
 		// for all other price pairs, iterate randomly, if we find a valid price, we return it
 		// otherwise we go onto the next PriceProvider to ask for prices.

feeder/priceprovider_test.go

@@ -9,7 +9,6 @@ import (
 	"github.com/NibiruChain/nibiru/v2/x/common/asset"
 	"github.com/NibiruChain/nibiru/v2/x/common/denoms"
 	"github.com/rs/zerolog"
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/NibiruChain/pricefeeder/sources"
@@ -191,39 +190,4 @@ func TestAggregatePriceProvider(t *testing.T) {
 		require.Equal(t, asset.NewPair("ustnibi", denoms.USD), price.Pair)
 		require.Equal(t, sources.SourceNameErisProtocol, price.SourceName)
 	})
-
-	t.Run(sources.SourceNameAvalon, func(t *testing.T) {
-		pp := NewAggregatePriceProvider(
-			map[string]map[asset.Pair]types.Symbol{
-				sources.SourceNameAvalon: {
-					"susda:usda": sources.Symbol_sUSDaUSDa,
-				},
-				sources.SourceNameUniswapV3: {
-					"usda:usd": sources.Symbol_UniswapV3_USDaUSD,
-				},
-			},
-			map[string]json.RawMessage{},
-			zerolog.New(io.Discard),
-		)
-		defer pp.Close()
-		<-time.After(sources.UpdateTick + 5*time.Second)
-
-		pair := asset.Pair("susda:usda")
-		price := pp.GetPrice(pair)
-		assert.Truef(t, price.Valid, "invalid price for %s", price.Pair)
-		assert.Equal(t, pair, price.Pair)
-		assert.Equal(t, sources.SourceNameAvalon, price.SourceName)
-
-		pair = asset.Pair("usda:usd")
-		price = pp.GetPrice(pair)
-		assert.Truef(t, price.Valid, "invalid price for %s", price.Pair)
-		assert.EqualValues(t, pair, price.Pair)
-		assert.Equal(t, sources.SourceNameUniswapV3, price.SourceName)
-
-		pair = asset.Pair("susda:usd")
-		price = pp.GetPrice(pair)
-		assert.Truef(t, price.Valid, "invalid price for %s", price.Pair)
-		assert.EqualValues(t, pair, price.Pair)
-		assert.Equal(t, sources.SourceNameAvalon, price.SourceName)
-	})
 }

sources/avalon_finance.go

@@ -159,16 +159,6 @@ var allSources = []NamedSource{
 			return NewTickSource(symbols, ErisProtocolPriceUpdate, logger)
 		},
 	},
-	{
-		Name: SourceNameUniswapV3,
-		F: func(
-			symbols set.Set[types.Symbol],
-			_ json.RawMessage,
-			logger zerolog.Logger,
-		) types.Source {
-			return NewTickSource(symbols, UniswapV3PriceUpdate, logger)
-		},
-	},
 	{
 		Name: SourceNameChainLink,
 		F: func(