Improved error on delete entitlement

Author: simonredfern

obp-api/src/main/scala/code/api/util/ErrorMessages.scala

@@ -921,7 +921,7 @@ object ErrorMessages {
     MeetingApiKeyNotConfigured -> 403,
     MeetingApiSecretNotConfigured -> 403,
     EntitlementNotFound -> 404,
-    EntitlementCannotBeDeleted -> 404,
+    EntitlementCannotBeDeleted -> 500,
     ConsentStatusIssue -> 401,
     ConsentDisabled -> 401,
     InternalServerError -> 500,

obp-api/src/main/scala/code/api/v2_0_0/APIMethods200.scala

@@ -1921,7 +1921,7 @@ trait APIMethods200 {
               } map { unboxFull(_) }
               _ <- Helper.booleanToFuture(UserDoesNotHaveEntitlement, cc=callContext) { entitlement.userId == userId }
               deleted <- Future(Entitlement.entitlement.vend.deleteEntitlement(Some(entitlement))) map {
-                x => fullBoxOrException(x ~> APIFailureNewStyle(EntitlementCannotBeDeleted, 404, callContext.map(_.toLight)))
+                x => fullBoxOrException(x ~> APIFailureNewStyle(EntitlementCannotBeDeleted, 500, callContext.map(_.toLight)))
               } map { unboxFull(_) }
             } yield (deleted, HttpCode.`204`(cc.callContext))
       }