Commit ab05134
authored
`crates/entity-derive-impl/src/entity/sql/postgres/save.rs::save_method`
already wrapped the INSERT in a transaction (#118 era), but for entities
with both `aggregate_root` and `streams` enabled it never spliced
`pg_notify`. Subscribers missed every new aggregate-root insert silently,
even though the row write itself was atomic.
Splice `self.notify_created()` into the existing transaction body, after
the INSERT but before the commit. The notify executes against
`&mut *tx`, the same handle the INSERT uses, so Postgres only broadcasts
`Created` on commit and discards it on rollback — the same guarantee
already in place for `create_method` (#125).
When `streams` is off, `notify_created()` returns an empty TokenStream,
so non-streams aggregate roots stay one round-trip with no regression.
Tests (3 new lib tests in `save::tests`):
- `save_emits_pg_notify_when_streams_enabled`: combined attribute set
produces a save body that contains `pg_notify` and executes it on
`&mut *tx`.
- `save_omits_pg_notify_when_streams_disabled`: aggregate_root without
streams does NOT emit `pg_notify` (perf regression guard).
- `save_is_empty_for_non_aggregate_root`: untouched control case —
`save_method` returns empty when aggregate_root is off.
Bump:
- entity-derive-impl: 0.6.3 -> 0.6.4
- entity-derive: 0.8.4 -> 0.8.5
`entity-core` is unchanged.
Closes #133
1 parent 2e5db58 commit ab05134
3 files changed
Lines changed: 87 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Lines changed: 85 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
78 | 86 | | |
79 | 87 | | |
80 | 88 | | |
| |||
89 | 97 | | |
90 | 98 | | |
91 | 99 | | |
| 100 | + | |
| 101 | + | |
92 | 102 | | |
93 | 103 | | |
94 | 104 | | |
95 | 105 | | |
96 | 106 | | |
97 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments