test(ls): complete unit test coverage

[Janmesh23]

Summary

This PR significantly enhances the test suite for the ls command by adding comprehensive unit test coverage for all internal functions. The implementation adds 43 new tests while carefully preserving all 5 existing tests, bringing the total to 48 passing tests.

Crucially, no production code was modified - this PR only extends test files to ensure the existing functionality remains stable and well-tested.

🎯 Problem & Solution

The Problem

The ls command's core internal functions had incomplete test coverage, leaving edge cases and error scenarios untested. This posed a risk for future refactoring and could allow regressions to go undetected.

The Solution

I systematically analyzed each internal function and created comprehensive test suites that cover:

• Normal operation under expected conditions
• Edge cases (empty inputs, boundary values, malformed data)
• Error scenarios and fallback behaviors
• All possible flag combinations and display modes

📁 Detailed Changes

Extended cmd/ls_helpers_test.go (+19 tests)

filterAndSortFiles Function Tests:

• ✅ Empty file list handling
• ✅ No matching files for filter path
• ✅ All sorting algorithms (name, size, time, default path)
• ✅ Reverse chronological ordering for time sort
• ✅ Case-insensitive sort parameter handling

buildChunkIndex Function Tests:

• ✅ Empty files and empty chunks handling
• ✅ Hash fallback logic (uses EncryptedHash when Hash is empty)
• ✅ Proper skipping of malformed chunks with empty identifiers
• ✅ Multiple files sharing the same chunks
• ✅ Full file path construction verification

displayLongFormat Function Tests:

• ✅ All flag combinations (tags on/off, dedup on/off)
• ✅ Empty file list with proper header display
• ✅ Time parsing and formatting verification
• ✅ Chunk count display accuracy
• ✅ Deduplication statistics integration

Created internal/ls/ui_test.go (+24 tests)

FormatSharedWith Function Tests:

• ✅ Empty list returns empty string
• ✅ Lists below/at/above truncation limits
• ✅ Single item handling
• ✅ Large lists (100+ items) with proper truncation
• ✅ Boundary conditions and zero limit edge cases

DisplayShortFormat Function Tests:

• ✅ Empty file list produces no output
• ✅ Basic file listing without additional data
• ✅ Tag display with various tag combinations
• ✅ Deduplication statistics with shared/unshared chunks
• ✅ Combined tags and dedup stats display
• ✅ Special characters and edge case file paths
• ✅ Large file lists performance and formatting

AI Assistance

• I used AI assistance (generate code, write tests, refactor, or docs)
  • Where: Generated comprehensive unit test cases for existing functions
  • How: Used AI to create test scenarios covering edge cases, boundary conditions, and all function combinations while following existing testing patterns in the codebase
  • Human Role: Reviewed, refined, and verified all tests work with the actual codebase

Hacktoberfest Notes

• Issue Link: 🧪 Add Tests for sietch ls #115
• Problem & Approach: The ls command lacked comprehensive test coverage for its core functions. I systematically added unit tests for each function, covering normal operation, edge cases, and error scenarios while preserving all existing tests to ensure backward compatibility.

Fixes: #115

[github-actions]

💡 Suggestions to Improve This PR

• ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

[Janmesh23]

Hi @SubstantialCattle5 !
This PR adds unit tests covering all ls command internal logic. No code changes - only tests.
I would like to know your suggestion on what more things need to be done .
thank you (also sorry for not being active for past few days)

[github-actions]

💡 Suggestions to Improve This PR

• ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

[github-actions]

💡 Suggestions to Improve This PR

• ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

[github-actions]

💡 Suggestions to Improve This PR

• ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[S4tvara]

@Janmesh23 ,
thanks for your contribution.
In future i'll suggest you to run make test-coverage as well and find out the total number of function covered by the tests.
should look something like this

[Janmesh23]

@Janmesh23 , thanks for your contribution. In future i'll suggest you to run make test-coverage as well and find out the total number of function covered by the tests. should look something like this

sure , tysm :)