Refactor add command: Separate concerns into modular architecture#140
Open
MrKeiKun wants to merge 1 commit intoS4tvara:mainfrom
Open
Refactor add command: Separate concerns into modular architecture#140MrKeiKun wants to merge 1 commit intoS4tvara:mainfrom
MrKeiKun wants to merge 1 commit intoS4tvara:mainfrom
Conversation
…ved maintainability Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the add.go command to address increasing complexity by separating concerns into a well-organized modular architecture.
core.go- Core file processing logicspace.go- Space calculations and reportingfiles.go- File operations and validationconfig.go- Configuration managementui.go- UI and progress handlingand of course, simplified
cmd/add.goas the one handling calls to different modules. I didn't also forget about test file.add/files_test.go- Cleaned-up its test since there way duplicated ones.cmd/add_test.go- just the one calling the tests.AI Assistance
Scope & Risk
Hacktoberfest Notes
add.godue to increasing complexity #98Checklist