fix(env): implement dual-layer script normalization for Windows compatibility

Add recursive host-side line ending normalization during setup and a robust
container-side normalization step using sed on startup. This ensures all
.sh scripts use LF line endings, resolving the 'bash\r' execution error
on Windows hosts.

Also includes minor lint fix in docker_patch.go.

Author: Scetrov

pkg/git/git.go

@@ -246,8 +246,9 @@ func NormalizeLineEndings(path string) error {
 		return err
 	}
 
-	// Simple CRLF to LF replacement
-	normalized := strings.ReplaceAll(string(data), "\r\n", "\n")
+	// Robust line ending normalization: strip all \r characters and
+	// then ensure the file uses LF (\n) correctly.
+	normalized := strings.ReplaceAll(string(data), "\r", "")
 
 	if normalized == string(data) {
 		return nil // No change needed

pkg/setup/deploy.go

@@ -28,6 +28,12 @@ func DeployWorld(c container.ContainerClient, workspace string) error {
 		return fmt.Errorf("sui-playground container is not running (ExitCode: %d, ExitErr: %v). Last 50 lines of logs:\n%s", exitCode, exitErr, lastLogs)
 	}
 
+	// 0. Ensure all scripts in the container have LF line endings.
+	// This protects against Windows host-side drift (CRLF).
+	if err := NormalizeContainerScripts(c, container.ContainerSuiPlayground); err != nil {
+		ui.Warn.Println(fmt.Sprintf("Script normalization failed (continuing): %v", err))
+	}
+
 	// 0. Remove stale Move.lock files so the Sui CLI resolves framework
 	//    dependencies from the installed binary instead of pinned git revisions
 	//    that may no longer exist upstream.
@@ -88,3 +94,19 @@ func DeployWorld(c container.ContainerClient, workspace string) error {
 
 	return nil
 }
+
+// NormalizeContainerScripts ensures all .sh files in the /workspace directory
+// inside the container have LF line endings. This is a critical safety net
+// for Windows users where bind-mounted scripts might drift to CRLF.
+func NormalizeContainerScripts(c container.ContainerClient, containerName string) error {
+	ui.Debug.Println(fmt.Sprintf("Normalizing script line endings in container %s...", containerName))
+
+	// Find all .sh files and use sed to strip all \r characters.
+	// This ensures scripts are safe for execution regardless of host OS.
+	cmd := []string{
+		"/bin/bash", "-c",
+		"find /workspace -name '*.sh' -exec sed -i 's/\\r//g' {} +",
+	}
+
+	return c.Exec(context.Background(), containerName, cmd)
+}

pkg/setup/docker_patch.go

@@ -62,9 +62,7 @@ func patchDockerfile(dockerDir string) {
 	if !strings.Contains(content, "postgresql-client") {
 		content = strings.Replace(content, "dos2unix \\", "dos2unix \\\n    postgresql-client \\", 1)
 	}
-	if strings.Contains(content, "ENV SUI_CONFIG_DIR=/root/.sui") {
-		content = strings.Replace(content, "ENV SUI_CONFIG_DIR=/root/.sui", "ENV SUI_CONFIG_DIR=/workspace/.sui", 1)
-	}
+	content = strings.Replace(content, "ENV SUI_CONFIG_DIR=/root/.sui", "ENV SUI_CONFIG_DIR=/workspace/.sui", 1)
 	// Safety net: inject a sed command into the Dockerfile that globally
 	// replaces the bind-mount .env.sui path with the internal config-dir path
 	// at build time.  This uses a broad global replacement (not just the

pkg/setup/setup.go

@@ -112,16 +112,21 @@ func CloneRepositories(g git.GitClient, workspace string) error {
 	}
 
 	// Correct line ending drift for critical shell scripts
-	scriptsToNormalize := []string{
-		filepath.Join(builderScaffoldPath, "docker/scripts/generate-world-env.sh"),
-	}
-
-	for _, script := range scriptsToNormalize {
-		if _, err := os.Stat(script); err == nil {
-			ui.Debug.Printfln("Normalizing line endings for %s", script)
-			git.NormalizeLineEndings(script)
-		}
-	}
+	normalizeScripts := func(root string) {
+		_ = filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
+			if err != nil {
+				return nil
+			}
+			if !info.IsDir() && strings.HasSuffix(strings.ToLower(info.Name()), ".sh") {
+				ui.Debug.Printfln("Normalizing line endings for %s", path)
+				git.NormalizeLineEndings(path)
+			}
+			return nil
+		})
+	}
+
+	normalizeScripts(builderScaffoldPath)
+	normalizeScripts(worldContractsPath)
 
 	return nil
 }

pkg/setup/start.go

@@ -131,6 +131,12 @@ func startSuiDev(c container.ContainerClient, ctx context.Context, workspace, do
 		return fmt.Errorf("failed to start sui-playground container: %w", err)
 	}
 
+	// 0. Ensure all scripts in the container have LF line endings.
+	// This protects against Windows host-side drift (CRLF).
+	if err := NormalizeContainerScripts(c, container.ContainerSuiPlayground); err != nil {
+		ui.Warn.Println(fmt.Sprintf("Script normalization failed (continuing): %v", err))
+	}
+
 	// Give the container a moment to start, then verify it is still running
 	// before entering the (potentially long) log-wait loop.
 	time.Sleep(10 * time.Second)