SMOODEV-1527: eso-refresher keep-alive — don't unref the interval (land stranded fix) (#125)

* SMOODEV-1527: Fix eso-refresher keep-alive (don't unref the interval)

The refresher exited 0 right after its initial mint+write — it unref'd the
interval timer, and the 'await new Promise(() => {})' keep-alive in main() does
NOT hold Node's event loop open on its own. Result: the sidecar CrashLoopBackOff'd
(re-minting on each restart, which masked it, but it's not a stable daemon).
Don't unref the production interval — it's what keeps the loop alive. Tests
inject their own scheduler, so they're unaffected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* SMOODEV-1527: fix stale keep-alive comment at the main() hold point

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LE7V35vzRiHyxBFE8wAxb4

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: brentrager

.changeset/eso-refresher-keepalive.md

@@ -0,0 +1,5 @@
+---
+'@smooai/config': patch
+---
+
+SMOODEV-1527: Fix the eso-refresher exiting immediately after its initial mint (it `unref()`'d the interval timer, and a pending `await new Promise(() => {})` doesn't hold Node's event loop open — so the process exited 0 → CrashLoopBackOff). The production interval now keeps the daemon alive; tests inject their own scheduler so they're unaffected.

src/eso-refresher/index.ts

@@ -147,8 +147,12 @@ export interface EsoRefresherHandle {
 
 function defaultScheduler(fn: () => void, ms: number): { clear: () => void } {
     const t = setInterval(fn, ms);
-    // Don't keep the event loop alive solely for the timer in tests/CLI teardown.
-    if (typeof t.unref === 'function') t.unref();
+    // SMOODEV-1527: do NOT unref() — the interval is what keeps the daemon's
+    // event loop alive. A pending `await new Promise(() => {})` in main() does
+    // NOT hold the loop open by itself, so unref'ing here let the process exit 0
+    // right after the initial mint → CrashLoopBackOff. Tests inject their own
+    // scheduler, so this only affects the real CLI/sidecar (where we WANT it
+    // to keep running). `stop()` still calls clear() for clean shutdown.
     return { clear: () => clearInterval(t) };
 }
 
@@ -245,6 +249,7 @@ export async function main(): Promise<void> {
     process.on('SIGTERM', () => shutdown('SIGTERM'));
     process.on('SIGINT', () => shutdown('SIGINT'));
 
-    // Keep alive — the interval timer is unref'd, so hold the loop open explicitly.
+    // The ref'd interval (SMOODEV-1527) is what actually holds the event loop
+    // open; this pending promise only keeps main() from returning.
     await new Promise<never>(() => {});
 }