fix(powersync): applyTransaction hangs forever when a transaction mixes delete+insert on one collection for a same-millisecond tie (#1649)

Fix for applyTransaction hangs forever when a transaction mixes delete+insert on one collection

Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
Co-authored-by: stevensJourney <steven@journeyapps.com>

Author: Chriztiaan

.changeset/hot-bats-camp.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/powersync-db-collection': patch
+---
+
+Fix: applyTransaction hangs forever when a transaction mixes delete+insert on one collection for a same-millisecond tie.

packages/powersync-db-collection/src/PowerSyncTransactor.ts

@@ -284,7 +284,7 @@ export class PowerSyncTransactor {
 
     // Need to get the operation in order to wait for it
     const diffOperation = await context.get<{ id: string; timestamp: string }>(
-      sanitizeSQL`SELECT id, timestamp FROM ${trackedTableName} ORDER BY timestamp DESC LIMIT 1`,
+      sanitizeSQL`SELECT id, timestamp FROM ${trackedTableName} ORDER BY operation_id DESC LIMIT 1`,
     )
     return {
       tableName,

packages/powersync-db-collection/tests/powersync.test.ts

@@ -17,7 +17,8 @@ import { describe, expect, it, onTestFinished, vi } from 'vitest'
 import { powerSyncCollectionOptions } from '../src'
 import { PowerSyncTransactor } from '../src/PowerSyncTransactor'
 import { TEST_DATABASE_IMPLEMENTATION } from './test-db-implementation'
-import type { AbstractPowerSyncDatabase } from '@powersync/node'
+import type { AbstractPowerSyncDatabase, LockContext } from '@powersync/node'
+import type { PendingMutation } from '@tanstack/db'
 
 const APP_SCHEMA = new Schema({
   users: new Table({
@@ -275,6 +276,70 @@ describePowerSync(`PowerSync Integration`, () => {
       ).true
     })
 
+    it(`should complete transactions that delete one key and insert another (same-millisecond tie)`, async () => {
+      const db = await createDatabase()
+
+      const options = powerSyncCollectionOptions({
+        database: db,
+        table: APP_SCHEMA.props.documents,
+      })
+      const collection = createCollection(options)
+      onTestFinished(() => collection.cleanup())
+      await collection.stateWhenReady()
+
+      // Seed the row which will be deleted in the transaction
+      await collection.insert({ id: `a`, name: `row a` }).isPersisted.promise
+
+      const { trackedTableName } = options.utils.getMeta()
+
+      class SameMillisecondTransactor extends PowerSyncTransactor {
+        protected override async handleDelete(
+          mutation: PendingMutation<any>,
+          context: LockContext,
+          waitForCompletion?: boolean,
+        ) {
+          const result = await super.handleDelete(
+            mutation,
+            context,
+            waitForCompletion,
+          )
+          // Simulate the same-millisecond tie: ensure the delete's diff row
+          // wins the `ORDER BY timestamp DESC` readback of the insert below.
+          await context.execute(
+            `UPDATE ${trackedTableName} SET timestamp = '9999-12-31T23:59:59.999Z'`,
+          )
+          return result
+        }
+      }
+
+      const transactor = new SameMillisecondTransactor({ database: db })
+
+      const tx = createTransaction({
+        autoCommit: false,
+        mutationFn: async ({ transaction }) => {
+          await transactor.applyTransaction(transaction)
+        },
+      })
+
+      tx.mutate(() => {
+        collection.delete(`a`)
+        collection.insert({ id: `b`, name: `row b` })
+      })
+
+      const outcome = await Promise.race([
+        tx.commit().then(() => `persisted` as const),
+        new Promise<`timed out`>((resolve) =>
+          setTimeout(() => resolve(`timed out`), 2_000),
+        ),
+      ])
+      expect(outcome).toBe(`persisted`)
+
+      const documents = await db.getAll<{ id: string }>(
+        `SELECT id FROM documents`,
+      )
+      expect(documents.map((doc) => doc.id)).toEqual([`b`])
+    })
+
     it(`should handle transactions with multiple collections`, async () => {
       const db = await createDatabase()
       await createTestData(db)