Add direct unit tests for install/start/wait helpers in `app/cli/local_llm/ollama.py`

[VaibhavUpreti]

Why This Matters

the lifecycle helpers are the failure-prone part of the local onboarding flow, but they are only lightly tested today.

Read First

• app/cli/local_llm/ollama.py

Scope

1. Add direct tests for is_installed(), start_server(), and wait_for_server().
2. Add at least one install-flow test for macOS and one for Linux without running the real commands.
3. Keep the existing model-tag and pull tests where they are.

Tests / Coverage

• tests/cli/test_local_llm_ollama_lifecycle.py
• cover is_installed()
• cover wait_for_server() success and timeout
• cover start_server() subprocess wiring
• cover platform-specific install branches with mocked confirmation prompts

Acceptance Criteria

• lifecycle helpers have direct tests
• tests do not invoke real package managers or real ollama
• current public helper names stay unchanged

[Dipxssi]

Hi @VaibhavUpreti, I'd like to work on this one next!

My plan is to add direct tests for the Ollama lifecycle helpers in tests/cli/test_local_llm_ollama_lifecycle.py. I will:

Mock shutil.which to test is_installed() without needing the real binary.
Mock subprocess.run and Popen to verify start_server() and pull_model() wiring.
Mock sys.platform and questionary to test the installation logic for both macOS (Homebrew) and Linux (curl) without actually running those commands.
Mock httpx.get to test wait_for_server() success and timeout scenarios.
I'll ensure all existing public helper names remain unchanged as per the criteria. Could you please assign this to me? Thanks!