[WIP] C++ linter and formatter (experimental) #48
JanPetterMGclang.yml
on: pull_request
PlatformIO environments
12s
Matrix: Format
Matrix: Tidy
Annotations
39 errors and 50 warnings
|
Tidy (wemos_d1_mini32)
Process completed with exit code 1.
|
|
|
|
|
|
Tidy (lolin_d32_pro)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (lolin_d32_pro)
The operation was canceled.
|
|
|
|
|
|
Tidy (lolin_d32)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (lolin_d32)
The operation was canceled.
|
|
|
|
|
|
Tidy (esp32-s3-devkitc-1)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (esp32-s3-devkitc-1)
The operation was canceled.
|
|
|
|
|
|
Tidy (lolin_s3_mini)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (lolin_s3_mini)
The operation was canceled.
|
|
|
|
|
|
Tidy (esp32-c3-devkitm-1)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (esp32-c3-devkitm-1)
The operation was canceled.
|
|
Tidy (seeed_xiao_esp32c3)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (seeed_xiao_esp32c3)
The operation was canceled.
|
|
Tidy (seeed_xiao_esp32s3)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (seeed_xiao_esp32s3)
The operation was canceled.
|
|
Tidy (seeed_xiao_esp32c6)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (seeed_xiao_esp32c6)
The operation was canceled.
|
|
Tidy (esp32-c6-devkitm-1)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (esp32-c6-devkitm-1)
The operation was canceled.
|
|
Tidy (adafruit_qtpy_esp32s2)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (adafruit_qtpy_esp32s2)
The operation was canceled.
|
|
Tidy (adafruit_qtpy_esp32s3_n4r2)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (adafruit_qtpy_esp32s3_n4r2)
The operation was canceled.
|
|
Tidy (adafruit_qtpy_esp32s3_nopsram)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (adafruit_qtpy_esp32s3_nopsram)
The operation was canceled.
|
|
Tidy (esp32-c5-devkitc-1)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (esp32-c5-devkitc-1)
The operation was canceled.
|
|
Tidy (esp32dev)
The strategy configuration was canceled because "tidy.wemos_d1_mini32" failed
|
|
Tidy (esp32dev)
The operation was canceled.
|
|
firmware/src/fonts/MiniFont.cpp:10:5 [bugprone-branch-clone]:
firmware/src/fonts/MiniFont.cpp#L10
repeated branch body in conditional chain
|
|
firmware/include/modes/AnimationMode.h:25:53 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/AnimationMode.h#L25
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/AnimationMode.h:21:53 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/AnimationMode.h#L21
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/AnimationMode.h:10:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/AnimationMode.h#L10
class 'AnimationMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/modes/FliesMode.h:23:20 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/FliesMode.h#L23
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/FliesMode.h:10:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/FliesMode.h#L10
class 'FliesMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
|
|
|
|
firmware/include/services/DeviceService.h:30:18 [cppcoreguidelines-non-private-member-variables-in-classes]:
firmware/include/services/DeviceService.h#L30
member variable 'taskHandle' has public visibility
|
|
firmware/include/services/DeviceService.h:8:7 [cppcoreguidelines-special-member-functions]:
firmware/include/services/DeviceService.h#L8
class 'DeviceService' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
|
|
|
|
|
|
|
|
firmware/src/handlers/TextHandler.cpp:68:13 [bugprone-infinite-loop]:
firmware/src/handlers/TextHandler.cpp#L68
this loop is infinite; none of its condition variables (_x) are updated in the loop body
|
|
|
|
firmware/src/handlers/TextHandler.cpp:41:21 [cppcoreguidelines-avoid-c-arrays]:
firmware/src/handlers/TextHandler.cpp#L41
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/src/handlers/TextHandler.cpp:32:17 [bugprone-branch-clone]:
firmware/src/handlers/TextHandler.cpp#L32
repeated branch body in conditional chain
|
|
firmware/src/services/ModesService.cpp:116:20 [readability-make-member-function-const]:
firmware/src/services/ModesService.cpp#L116
method 'setMode' can be made const
|
|
|
|
firmware/include/extensions/RtcExtension.h:14:7 [cppcoreguidelines-special-member-functions]:
firmware/include/extensions/RtcExtension.h#L14
class 'RtcExtension' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/modes/CountdownMode.h:9:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/CountdownMode.h#L9
class 'CountdownMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/fonts/SmallFont.h:9:7 [cppcoreguidelines-special-member-functions]:
firmware/include/fonts/SmallFont.h#L9
class 'SmallFont' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
|
|
|
|
|
|
|
|
|
|
|
|
firmware/src/extensions/MessageExtension.cpp:15:1 [cppcoreguidelines-pro-type-member-init]:
firmware/src/extensions/MessageExtension.cpp#L15
constructor does not initialize these fields: frame, messages
|
|
firmware/src/services/ConnectivityService.cpp:132:61 [bugprone-casting-through-void]:
firmware/src/services/ConnectivityService.cpp#L132
do not cast '<dependent type>' to 'const char *' through 'const void *'; use reinterpret_cast instead
|
|
firmware/src/services/ConnectivityService.cpp:128:58 [bugprone-casting-through-void]:
firmware/src/services/ConnectivityService.cpp#L128
do not cast '<dependent type>' to 'const char *' through 'const void *'; use reinterpret_cast instead
|
|
|
|
firmware/include/services/ConnectivityService.h:61:41 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/services/ConnectivityService.h#L61
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/services/ConnectivityService.h:60:43 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/services/ConnectivityService.h#L60
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/services/ConnectivityService.h:9:7 [cppcoreguidelines-special-member-functions]:
firmware/include/services/ConnectivityService.h#L9
class 'ConnectivityService' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
|
|
|
|
|
|
|
|
firmware/src/handlers/TextHandler.cpp:41:21 [cppcoreguidelines-avoid-c-arrays]:
firmware/src/handlers/TextHandler.cpp#L41
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/src/handlers/TextHandler.cpp:32:17 [bugprone-branch-clone]:
firmware/src/handlers/TextHandler.cpp#L32
repeated branch body in conditional chain
|
|
firmware/include/modes/StarsMode.h:21:5 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/StarsMode.h#L21
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/StarsMode.h:8:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/StarsMode.h#L8
class 'StarsMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/modes/OpenMeteoMode.h:11:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/OpenMeteoMode.h#L11
class 'OpenMeteoMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/modes/MetaballsMode.h:29:5 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/MetaballsMode.h#L29
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/MetaballsMode.h:27:26 [cppcoreguidelines-avoid-c-arrays]:
firmware/include/modes/MetaballsMode.h#L27
do not declare C-style arrays, use 'std::array' instead
|
|
firmware/include/modes/MetaballsMode.h:8:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/MetaballsMode.h#L8
class 'MetaballsMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/include/modes/SmallClockMode.h:7:7 [cppcoreguidelines-special-member-functions]:
firmware/include/modes/SmallClockMode.h#L7
class 'SmallClockMode' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator
|
|
firmware/src/fonts/MiniFont.cpp:10:5 [bugprone-branch-clone]:
firmware/src/fonts/MiniFont.cpp#L10
repeated branch body in conditional chain
|