From 1cd828d047d0d6d0f8afff9cfa7cb7bb8e76e852 Mon Sep 17 00:00:00 2001 From: alliasgher Date: Sat, 2 May 2026 15:36:23 +0500 Subject: [PATCH] fix(backup): stop passing deprecated -eula flag to vmbackupmanager The -eula flag was deprecated in VictoriaMetrics and will be removed, which would cause a startup error in vmbackupmanager. Remove the two places where the operator appended -eula to the container args so that vmbackupmanager starts cleanly on current and future VictoriaMetrics versions. The AcceptEULA field on the CR is left in place for backward compatibility (existing configs that set it will keep working without producing a flag the binary no longer recognises). Fixes #1319 Signed-off-by: alliasgher --- internal/controller/operator/factory/build/backup.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/controller/operator/factory/build/backup.go b/internal/controller/operator/factory/build/backup.go index c0c2707e0..c8a5c737f 100644 --- a/internal/controller/operator/factory/build/backup.go +++ b/internal/controller/operator/factory/build/backup.go @@ -55,9 +55,7 @@ func VMBackupManager( fmt.Sprintf("-snapshot.createURL=%s", snapshotCreateURL), fmt.Sprintf("-snapshot.deleteURL=%s", snapshotDeleteURL), } - if cr.AcceptEULA { - args = append(args, "-eula") - } + // -eula flag was deprecated and removed from VictoriaMetrics; no longer passed. if cr.LogLevel != nil { args = append(args, fmt.Sprintf("-loggerLevel=%s", *cr.LogLevel)) } @@ -179,9 +177,7 @@ func VMRestore( args := []string{ fmt.Sprintf("-storageDataPath=%s", storagePath), } - if cr.AcceptEULA { - args = append(args, "-eula") - } + // -eula flag was deprecated and removed from VictoriaMetrics; no longer passed. if cr.LogLevel != nil { args = append(args, fmt.Sprintf("-loggerLevel=%s", *cr.LogLevel)) }