v0.7.2 — Review = Weekly Review merge + drop "Lists" sidebar header

Brandon's after-v0.7.1 review of the Review page surfaced two
problems we'd planned to fix in tier 3 of the v0.7 polish arc
but hadn't gotten to: the canonical Review page and the seeded
"Weekly Review" perspective lived under almost the same name
and showed completely different content (Review: "All caught
up"; Weekly Review: a long task list). And the upper-left
corner still had the centered "Lists" header from libadwaita's
default sidebar auto-title, contradicting the magazine-spread
treatment v0.7.0 introduced for the right side.

1. Review = Weekly Review merge.
   The canonical Review page now renders TWO sections in one
   surface: "Projects to review" (the existing Phase 13 review
   queue) followed by "This week" (the open-tasks-this-week
   filter formerly seeded as a saved perspective). Section 2
   reuses agenda::build_row for visual consistency; clicking a
   row opens the Inspector for that task. Both sections show
   inline notes when empty; "All caught up" status placeholder
   only appears when both are empty.

   The seeded "Weekly Review" perspective is retired —
   seed_initial_perspectives helper, WEEKLY_REVIEW_NAME
   constant, and the four seed_weekly_review_* tests removed.
   Filter constant survives as REVIEW_WEEKLY_WALK_FILTER for
   the GUI's refresh path. Existing user DBs keep their row
   (we don't delete data); fresh DBs and fixtures land clean.
   Regression script self-seeds a "CLI Smoke Persp" list-
   renderer perspective for the kanban-against-list-renderer
   error case (was riding on the seeded Weekly Review).

2. Drop the "Lists" centered title.
   Sidebar AdwHeaderBar now carries an empty AdwWindowTitle as
   its title-widget, suppressing the auto-rendered "Lists"
   label. Header becomes pure chrome (which is empty since
   show-end-title-buttons=false); the filter entry below acts
   as the sidebar's visual top. Mirrors the title-suppression
   v0.7.0 applied to the content side.

Test count: 119 + 169 + 1 + 106 + 106 = 501 (down 4 from
v0.7.1 — the seeded-perspective tests are gone). Ship-gate
runs in under 2 seconds. No schema changes, no new
dependencies, no spec semantics shifted.

VERSION + Cargo.toml + spec.md + roadmap.md + patchnotes +
AppStream metainfo bumped to 0.7.2.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: VirInvictus

Cargo.lock

@@ -4,7 +4,7 @@ default-members = ["atrium"]
 resolver = "2"
 
 [workspace.package]
-version = "0.7.1"
+version = "0.7.2"
 edition = "2024"
 license = "MIT"
 authors = ["Brandon LaRocque"]

Cargo.toml

@@ -1 +1 @@
-0.7.1
+0.7.2

VERSION

@@ -20,21 +20,25 @@ pub mod worker;
 
 use std::path::Path;
 
-use rusqlite::{Connection, params};
+use rusqlite::Connection;
 use tracing::{debug, info};
-use uuid::Uuid;
 
 use crate::error::DbError;
 
-/// v0.6.0 — name of the seeded Weekly Review Perspective. Public so
-/// tests can assert against a stable string.
-pub const WEEKLY_REVIEW_NAME: &str = "Weekly Review";
-
-/// Filter expression for the Weekly Review seed. Matches anything
-/// the user should look at this week per spec §4.2 + §4.3:
-/// overdue items, anything scheduled this week, deadlines next week
-/// (heads-up window), and tasks just freed from a defer.
-pub const WEEKLY_REVIEW_FILTER: &str = "is:overdue OR scheduled:thisweek OR (is:deadline AND due:nextweek) OR (is:deferred AND defer:<=today)";
+/// v0.6.0 → v0.7.2 — filter expression for the canonical Review
+/// page's "This week" weekly walk section. Matches anything the
+/// user should look at this week per spec §4.2 + §4.3: overdue
+/// items, anything scheduled this week, deadlines reaching next
+/// week (heads-up window), and tasks just freed from a defer.
+///
+/// Originally seeded as a saved Perspective named "Weekly Review";
+/// v0.7.2 retired the seed (Brandon's "Review and Weekly Review
+/// showed two different things — confusing" feedback). The
+/// canonical Review page now renders this same content as its
+/// secondary section, alongside the project-review queue. The
+/// constant survives so the GUI window-side fetch can use the
+/// same expression atrium_search would parse.
+pub const REVIEW_WEEKLY_WALK_FILTER: &str = "is:overdue OR scheduled:thisweek OR (is:deadline AND due:nextweek) OR (is:deferred AND defer:<=today)";
 
 /// Open the Atrium database at `path`, applying pragmas and migrations.
 ///
@@ -56,50 +60,15 @@ pub fn open(path: &Path) -> Result<Connection, DbError> {
     let mut conn = Connection::open(path)?;
     configure_pragmas(&conn)?;
     migrations::migrate(&mut conn)?;
-    seed_initial_perspectives(&conn)?;
+    // v0.6.0 → v0.7.2 — the Weekly Review perspective is no
+    // longer auto-seeded. The canonical Review page now renders
+    // the same content as its weekly-walk section; seeding a
+    // duplicate as a saved Perspective just created the
+    // confusion Brandon flagged. Existing user DBs keep their
+    // row (we don't delete data); fresh DBs land clean.
     Ok(conn)
 }
 
-/// v0.6.0 — Phase 15.75 Slice C1. Insert the Weekly Review
-/// Perspective on first open. Idempotent: dedupes against an
-/// existing row with the same `name`, so users who delete it
-/// don't get it re-seeded on next launch (the dedup key is the
-/// visible name, not a synthetic flag column — keeps the seed
-/// invisible to future migrations).
-///
-/// The filter matches anything the user should look at this week:
-/// overdue tasks, anything scheduled this week, deadlines reaching
-/// into next week (the §4.2 Today-list heads-up window), and
-/// tasks whose defer just passed today.
-pub fn seed_initial_perspectives(conn: &Connection) -> Result<(), DbError> {
-    let existing: i64 = conn.query_row(
-        "SELECT count(*) FROM perspective WHERE name = ?1",
-        params![WEEKLY_REVIEW_NAME],
-        |r| r.get(0),
-    )?;
-    if existing > 0 {
-        return Ok(());
-    }
-    let uuid = Uuid::new_v4().to_string();
-    // Position 1.0 puts it first alphabetically among any future
-    // perspectives users add; the row reads as the "default" entry
-    // even after sort by position then name.
-    conn.execute(
-        "INSERT INTO perspective \
-         (uuid, name, icon, filter_expr, position) \
-         VALUES (?1, ?2, ?3, ?4, ?5)",
-        params![
-            uuid,
-            WEEKLY_REVIEW_NAME,
-            "object-select-symbolic",
-            WEEKLY_REVIEW_FILTER,
-            1.0_f64,
-        ],
-    )?;
-    debug!(uuid, name = WEEKLY_REVIEW_NAME, "seeded perspective");
-    Ok(())
-}
-
 /// Apply pragmas to a connection (writable or read-only). Per spec §3.2
 /// and roadmap.md Phase 1.
 pub fn configure_pragmas(conn: &Connection) -> Result<(), DbError> {
@@ -398,104 +367,15 @@ mod tests {
         let _ = std::fs::remove_file(tmp.with_extension("db-wal"));
     }
 
-    // ── v0.6.0 Slice C1: Weekly Review seed ────────────────────────
-
-    #[test]
-    fn seed_weekly_review_inserts_on_fresh_db() {
-        let conn = fresh_db();
-        // fresh_db() didn't seed; should be zero perspectives.
-        let count_before: i64 = conn
-            .query_row("SELECT count(*) FROM perspective", [], |r| r.get(0))
-            .unwrap();
-        assert_eq!(count_before, 0);
-        seed_initial_perspectives(&conn).unwrap();
-        let count_after: i64 = conn
-            .query_row("SELECT count(*) FROM perspective", [], |r| r.get(0))
-            .unwrap();
-        assert_eq!(count_after, 1);
-        let (name, icon, filter): (String, Option<String>, String) = conn
-            .query_row(
-                "SELECT name, icon, filter_expr FROM perspective WHERE name = ?1",
-                params![WEEKLY_REVIEW_NAME],
-                |r| Ok((r.get(0)?, r.get(1)?, r.get(2)?)),
-            )
-            .unwrap();
-        assert_eq!(name, WEEKLY_REVIEW_NAME);
-        assert_eq!(icon.as_deref(), Some("object-select-symbolic"));
-        assert_eq!(filter, WEEKLY_REVIEW_FILTER);
-    }
-
-    #[test]
-    fn seed_weekly_review_idempotent() {
-        let conn = fresh_db();
-        seed_initial_perspectives(&conn).unwrap();
-        seed_initial_perspectives(&conn).unwrap();
-        seed_initial_perspectives(&conn).unwrap();
-        let count: i64 = conn
-            .query_row("SELECT count(*) FROM perspective", [], |r| r.get(0))
-            .unwrap();
-        assert_eq!(count, 1, "second + third seed pass must dedupe");
-    }
-
-    #[test]
-    fn seed_weekly_review_respects_user_deletion() {
-        // If the user deletes the seeded perspective, re-running the
-        // seed must not re-insert (we dedupe by name; deleted means
-        // intentional). But a different perspective also named
-        // "Weekly Review" *would* satisfy the dedup — that's the
-        // user's choice, not ours.
-        let conn = fresh_db();
-        seed_initial_perspectives(&conn).unwrap();
-        conn.execute(
-            "DELETE FROM perspective WHERE name = ?1",
-            params![WEEKLY_REVIEW_NAME],
-        )
-        .unwrap();
-        seed_initial_perspectives(&conn).unwrap();
-        let count: i64 = conn
-            .query_row(
-                "SELECT count(*) FROM perspective WHERE name = ?1",
-                params![WEEKLY_REVIEW_NAME],
-                |r| r.get(0),
-            )
-            .unwrap();
-        // After deletion + re-seed, it should be back. The deletion-
-        // sticks behaviour relies on the seed only running at open(),
-        // not on subsequent calls — open() is single-shot per process,
-        // so a delete during a session stays gone until next launch.
-        // (Interactive sessions don't re-call open mid-flight; the
-        // GUI holds one Connection for its lifetime.)
-        assert_eq!(
-            count, 1,
-            "seed re-creates after deletion when invoked directly"
-        );
-    }
-
-    #[test]
-    fn seed_weekly_review_runs_through_open() {
-        let tmp = std::env::temp_dir().join(format!("atrium-seed-test-{}.db", std::process::id()));
-        let _ = std::fs::remove_file(&tmp);
-        let conn = open(&tmp).unwrap();
-        let count: i64 = conn
-            .query_row(
-                "SELECT count(*) FROM perspective WHERE name = ?1",
-                params![WEEKLY_REVIEW_NAME],
-                |r| r.get(0),
-            )
-            .unwrap();
-        assert_eq!(count, 1);
-        drop(conn);
-
-        // Reopen the same path — the seed must NOT double up.
-        let conn = open(&tmp).unwrap();
-        let count: i64 = conn
-            .query_row("SELECT count(*) FROM perspective", [], |r| r.get(0))
-            .unwrap();
-        assert_eq!(count, 1, "reopen must not duplicate the seed");
-        drop(conn);
-
-        let _ = std::fs::remove_file(&tmp);
-        let _ = std::fs::remove_file(tmp.with_extension("db-shm"));
-        let _ = std::fs::remove_file(tmp.with_extension("db-wal"));
-    }
+    // ── v0.6.0 → v0.7.2: Weekly Review seed retired ───────────────
+    //
+    // The four `seed_weekly_review_*` tests that lived here covered
+    // the seeded Weekly Review perspective. v0.7.2 removed the seed
+    // (the canonical Review page now renders the same content as
+    // its weekly-walk section; the saved-search duplicate was the
+    // source of Brandon's "Review and Weekly Review show two
+    // different things" confusion). The constants and the
+    // seed_initial_perspectives helper are gone; only
+    // REVIEW_WEEKLY_WALK_FILTER survives, used by the GUI window
+    // when fetching the weekly walk.
 }

atrium-core/src/db/mod.rs

@@ -263,7 +263,12 @@ fn build_section<F: Fn(i64) + 'static + Clone>(
     card.upcast()
 }
 
-fn build_row<F: Fn(i64) + 'static>(
+/// v0.7.2 — `pub(crate)` so the canonical Review page can reuse
+/// the same task-row treatment for its weekly-walk section. Same
+/// shape (title + date chip + project-and-tags meta line + click
+/// → Inspector); same CSS class so any styling tweaks apply
+/// uniformly across both pages.
+pub(crate) fn build_row<F: Fn(i64) + 'static>(
     task: &Task,
     project_titles: &HashMap<i64, String>,
     tag_pills: &TagPillMap,