PLATFORM-11180| port some changes for DPL Hooks from previous release

Author: harnash

includes/Hooks.php

@@ -219,7 +219,7 @@ private static function executeTag( $input, array $args, Parser $parser, PPFrame
 
 		// we can remove the templates by save/restore
 		if ( $reset['templates'] ?? false ) {
-			$saveTemplates = $parserOutput->mTemplates;
+			$saveTemplates = $parserOutput->getLinkList( ParserOutputLinkTypes::TEMPLATE );
 		}
 
 		// we can remove the categories by save/restore
@@ -234,7 +234,7 @@ private static function executeTag( $input, array $args, Parser $parser, PPFrame
 
 		// we can remove the images by save/restore
 		if ( $reset['images'] ?? false ) {
-			$saveImages = $parserOutput->mImages;
+			$saveImages = $parserOutput->getLinkList( ParserOutputLinkTypes::MEDIA );
 		}
 
 		$parsedDPL = $parser->recursiveTagParse( $text );
@@ -619,39 +619,37 @@ public static function endEliminate( $parser, &$text ) {
 		// called during the final output phase; removes links created by DPL
 		if ( self::$createdLinks ) {
 			if ( array_key_exists( 0, self::$createdLinks ) ) {
-				$parserLinks = $parser->getOutput()->mLinks;
-				foreach ( $parserLinks as $nsp => $_ ) {
+				$parserLinks = $parser->getOutput()->getLinkList( ParserOutputLinkTypes::LOCAL );
+				foreach ( $parserLinks as $nsp => $link ) {
 					if ( !array_key_exists( $nsp, self::$createdLinks[0] ) ) {
 						continue;
 					}
 
-					$mLinks = $parser->getOutput()->mLinks;
-					$mLinks[$nsp] = array_diff_assoc(
+					$parser->getOutput()->mLinks[$nsp] = array_diff_assoc(
 						$link,
 						self::$createdLinks[0][$nsp]
 					);
 
 					if ( count( $link ) == 0 ) {
-						unset( $mLinks[$nsp] );
+						unset( $parser->getOutput()->mLinks[$nsp] );
 					}
 				}
 			}
 
 			if ( array_key_exists( 1, self::$createdLinks ) ) {
-				$parserTemplates = $parser->getOutput()->mTemplates;
-				foreach ( $parserTemplates as $nsp => $_ ) {
+				$parserTemplates = $parser->getOutput()->getLinkList( ParserOutputLinkTypes::TEMPLATE );
+				foreach ( $parserTemplates as $nsp => $tpl ) {
 					if ( !array_key_exists( $nsp, self::$createdLinks[1] ) ) {
 						continue;
 					}
 
-					$mTemplates = $parser->getOutput()->mTemplates;
-					$mTemplates[$nsp] = array_diff_assoc(
+					$parser->getOutput()->mTemplates[$nsp] = array_diff_assoc(
 						$tpl,
 						self::$createdLinks[1][$nsp]
 					);
 
 					if ( count( $tpl ) == 0 ) {
-						unset( $mTemplates[$nsp] );
+						unset( $parser->getOutput()->mTemplates[$nsp] );
 					}
 				}
 			}
@@ -669,7 +667,8 @@ public static function endEliminate( $parser, &$text ) {
 			}
 
 			if ( array_key_exists( 3, self::$createdLinks ) ) {
-				$parser->getOutput()->mImages = array_diff_assoc( $parser->getOutput()->mImages, self::$createdLinks[3] );
+				$parserMedia = $parser->getOutput()->getLinkList( ParserOutputLinkTypes::MEDIA );
+				$parser->getOutput()->mImages = array_diff_assoc( $parserMedia, self::$createdLinks[3] );
 			}
 		}
 	}