refactor(maps): extract the shared map-texture candidate resolver

HuntZoneMapTextures and HousingGameMaps each carried their own copy of
TextureCandidates/FileExists/ResolveTexturePath, with Hunts silently
missing the _s.tex fallback candidate Housing had. Extract both into
Core/Maps/MapTextures, keeping all five candidates so the two callers
stay behaviorally identical; both now pass a subsystem label through
for the existing Debug-level 'could not test' log line.

Author: Deldee

src/Aetherphone/Core/Housing/HousingGameMaps.cs

@@ -1,4 +1,5 @@
 using System.Text;
+using Aetherphone.Core.Maps;
 using Dalamud.Interface.Textures.TextureWraps;
 using Dalamud.Plugin.Services;
 using Lumina.Excel.Sheets;
@@ -306,51 +307,8 @@ private Dictionary<uint, List<Vector3>> CollectMarkerGroups(uint districtId)
     private static float Normalize(float world, short offset, float scaleFactor) =>
         ((world + offset) * scaleFactor + MapPageSize * 0.5f) / MapPageSize;
 
-    private string? ResolveTexturePath(string mapId)
-    {
-        if (string.IsNullOrEmpty(mapId))
-        {
-            return null;
-        }
-
-        var candidates = TextureCandidates(mapId);
-        for (var index = 0; index < candidates.Length; index++)
-        {
-            if (FileExists(candidates[index]))
-            {
-                return candidates[index];
-            }
-        }
-
-        return null;
-    }
-
-    private static string[] TextureCandidates(string mapId)
-    {
-        var flat = mapId.Replace("/", string.Empty);
-        var underscored = mapId.Replace('/', '_');
-        return
-        [
-            $"ui/map/{mapId}/{flat}_m.tex",
-            $"ui/map/{mapId}/{flat}m_m.tex",
-            $"ui/map/{mapId}/{flat}_s.tex",
-            $"ui/map/{mapId}/{underscored}_m.tex",
-            $"ui/map/{mapId}/{underscored}m_m.tex",
-        ];
-    }
-
-    private bool FileExists(string path)
-    {
-        try
-        {
-            return data.FileExists(path);
-        }
-        catch (Exception exception)
-        {
-            AepLog.Debug(exception, $"Housing could not test '{path}'");
-            return false;
-        }
-    }
+    private string? ResolveTexturePath(string mapId) =>
+        string.IsNullOrEmpty(mapId) ? null : MapTextures.ResolveTexturePath(data, mapId, "Housing");
 
     public string Describe(uint districtId)
     {
@@ -406,10 +364,11 @@ private void DescribeGroup(StringBuilder report, uint mapRowId, List<Vector3> ma
         }
 
         report.Append($"  sizeFactor {map.SizeFactor} offset {map.OffsetX},{map.OffsetY}\n");
-        var candidates = TextureCandidates(mapId);
+        var candidates = MapTextures.Candidates(mapId);
         for (var index = 0; index < candidates.Length; index++)
         {
-            report.Append($"  texture: {candidates[index]} -> {(FileExists(candidates[index]) ? "OK" : "missing")}\n");
+            report.Append(
+                $"  texture: {candidates[index]} -> {(MapTextures.FileExists(data, candidates[index], "Housing") ? "OK" : "missing")}\n");
         }
 
         var sampleCount = Math.Min(3, markers.Count);

src/Aetherphone/Core/Hunts/HuntZoneMapTextures.cs

@@ -1,4 +1,4 @@
-using Aetherphone.Core.Media;
+using Aetherphone.Core.Maps;
 using Dalamud.Interface.Textures.TextureWraps;
 using Dalamud.Plugin.Services;
 using Lumina.Excel.Sheets;
@@ -63,46 +63,6 @@ public HuntZoneMapTextures(IDataManager data, ITextureProvider textures)
         }
 
         var mapId = map.Id.ExtractText();
-        if (mapId.Length == 0)
-        {
-            return null;
-        }
-
-        var candidates = TextureCandidates(mapId);
-        for (var index = 0; index < candidates.Length; index++)
-        {
-            if (FileExists(candidates[index]))
-            {
-                return candidates[index];
-            }
-        }
-
-        return null;
-    }
-
-    private static string[] TextureCandidates(string mapId)
-    {
-        var flat = mapId.Replace("/", string.Empty);
-        var underscored = mapId.Replace('/', '_');
-        return
-        [
-            $"ui/map/{mapId}/{flat}_m.tex",
-            $"ui/map/{mapId}/{flat}m_m.tex",
-            $"ui/map/{mapId}/{underscored}_m.tex",
-            $"ui/map/{mapId}/{underscored}m_m.tex",
-        ];
-    }
-
-    private bool FileExists(string path)
-    {
-        try
-        {
-            return data.FileExists(path);
-        }
-        catch (Exception exception)
-        {
-            AepLog.Debug(exception, $"Hunts could not test '{path}'");
-            return false;
-        }
+        return mapId.Length == 0 ? null : MapTextures.ResolveTexturePath(data, mapId, "Hunts");
     }
 }

src/Aetherphone/Core/Maps/MapTextures.cs

@@ -0,0 +1,47 @@
+using Dalamud.Plugin.Services;
+
+namespace Aetherphone.Core.Maps;
+
+internal static class MapTextures
+{
+    public static string[] Candidates(string mapId)
+    {
+        var flat = mapId.Replace("/", string.Empty);
+        var underscored = mapId.Replace('/', '_');
+        return
+        [
+            $"ui/map/{mapId}/{flat}_m.tex",
+            $"ui/map/{mapId}/{flat}m_m.tex",
+            $"ui/map/{mapId}/{flat}_s.tex",
+            $"ui/map/{mapId}/{underscored}_m.tex",
+            $"ui/map/{mapId}/{underscored}m_m.tex",
+        ];
+    }
+
+    public static string? ResolveTexturePath(IDataManager data, string mapId, string subsystem)
+    {
+        var candidates = Candidates(mapId);
+        for (var index = 0; index < candidates.Length; index++)
+        {
+            if (FileExists(data, candidates[index], subsystem))
+            {
+                return candidates[index];
+            }
+        }
+
+        return null;
+    }
+
+    public static bool FileExists(IDataManager data, string path, string subsystem)
+    {
+        try
+        {
+            return data.FileExists(path);
+        }
+        catch (Exception exception)
+        {
+            AepLog.Debug(exception, $"{subsystem} could not test '{path}'");
+            return false;
+        }
+    }
+}