... I know I'm very boring

[davide-alghi]

... but when there is something I don't understand it's like I have a little pebble in my shoe that torments me 😁

I had already opened a discussion about Profit, Margin and Markup: #12574
But now I notice a strange thing that I don't understand.
Sales Orders lineitems

in the lineitems the Percentage Margin - Margin (%) - is calculated with

((Price after discount - Purchase) / Purchase) * 100

that's

(Profit / Cost) * 100

putting aside the fact that, for me, it's the Markup and not the Margin, I do not understand why, in the totals row, the Margin (%) total is calculated with

((SUM(Price after discount) - SUM(Purchase)) / SUM(Price after discount)) * 100

that's

(Profit / Revenue) * 100

this is a completely different calculation (and in this case it would be, from my point of view, the correct value for the Margin (%)) than the one used for each single lineitem.

I'd like to understand why and if I'm wrong.

However, beyond this, when I generate a new Sales Order via workflow task, the entity fields "sum_*" are not calculated:

• sum_total (Net total)
• sum_gross (Gross amount)
• sum_discount (Discount amount)
• sum_margin (Total margin)
• sum_marginp (Total margin percentage)

YetiForceCRM/modules/Vtiger/models/Record.php

Line 1306 in 1daf10d

$this->set('sum_' . $fieldName, $value);