Merge pull request #2290 from ably/fix/liveobjects-92000-status

Report error 92000 with HTTP status 400, not 500

Author: lmars

src/plugins/liveobjects/livecounter.ts

@@ -105,7 +105,7 @@ export class LiveCounter extends LiveObject<LiveCounterData, LiveCounterUpdate>
       throw new this._client.ErrorInfo(
         `Cannot apply object operation with objectId=${op.objectId}, to this LiveCounter with objectId=${this.getObjectId()}`,
         92000,
-        500,
+        400,
       );
     }
 
@@ -180,14 +180,14 @@ export class LiveCounter extends LiveObject<LiveCounterData, LiveCounterUpdate>
   overrideWithObjectState(objectMessage: ObjectMessage): LiveCounterUpdate | LiveObjectUpdateNoop {
     const objectState = objectMessage.object;
     if (objectState == null) {
-      throw new this._client.ErrorInfo(`Missing object state; LiveCounter objectId=${this.getObjectId()}`, 92000, 500);
+      throw new this._client.ErrorInfo(`Missing object state; LiveCounter objectId=${this.getObjectId()}`, 92000, 400);
     }
 
     if (objectState.objectId !== this.getObjectId()) {
       throw new this._client.ErrorInfo(
         `Invalid object state: object state objectId=${objectState.objectId}; LiveCounter objectId=${this.getObjectId()}`,
         92000,
-        500,
+        400,
       );
     }
 
@@ -197,15 +197,15 @@ export class LiveCounter extends LiveObject<LiveCounterData, LiveCounterUpdate>
         throw new this._client.ErrorInfo(
           `Invalid object state: object state createOp objectId=${objectState.createOp?.objectId}; LiveCounter objectId=${this.getObjectId()}`,
           92000,
-          500,
+          400,
         );
       }
 
       if (objectState.createOp.action !== ObjectOperationAction.COUNTER_CREATE) {
         throw new this._client.ErrorInfo(
           `Invalid object state: object state createOp action=${objectState.createOp?.action}; LiveCounter objectId=${this.getObjectId()}`,
           92000,
-          500,
+          400,
         );
       }
     }

src/plugins/liveobjects/livemap.ts

@@ -301,7 +301,7 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
       throw new this._client.ErrorInfo(
         `Cannot apply object operation with objectId=${op.objectId}, to this LiveMap with objectId=${this.getObjectId()}`,
         92000,
-        500,
+        400,
       );
     }
 
@@ -390,22 +390,22 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
   overrideWithObjectState(objectMessage: ObjectMessage): LiveMapUpdate<T> | LiveObjectUpdateNoop {
     const objectState = objectMessage.object;
     if (objectState == null) {
-      throw new this._client.ErrorInfo(`Missing object state; LiveMap objectId=${this.getObjectId()}`, 92000, 500);
+      throw new this._client.ErrorInfo(`Missing object state; LiveMap objectId=${this.getObjectId()}`, 92000, 400);
     }
 
     if (objectState.objectId !== this.getObjectId()) {
       throw new this._client.ErrorInfo(
         `Invalid object state: object state objectId=${objectState.objectId}; LiveMap objectId=${this.getObjectId()}`,
         92000,
-        500,
+        400,
       );
     }
 
     if (objectState.map?.semantics !== this._semantics) {
       throw new this._client.ErrorInfo(
         `Invalid object state: object state map semantics=${objectState.map?.semantics}; LiveMap semantics=${this._semantics}`,
         92000,
-        500,
+        400,
       );
     }
 
@@ -415,23 +415,23 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
         throw new this._client.ErrorInfo(
           `Invalid object state: object state createOp objectId=${objectState.createOp?.objectId}; LiveMap objectId=${this.getObjectId()}`,
           92000,
-          500,
+          400,
         );
       }
 
       if (objectState.createOp.action !== ObjectOperationAction.MAP_CREATE) {
         throw new this._client.ErrorInfo(
           `Invalid object state: object state createOp action=${objectState.createOp?.action}; LiveMap objectId=${this.getObjectId()}`,
           92000,
-          500,
+          400,
         );
       }
 
       if (objectState.createOp.mapCreate?.semantics !== this._semantics) {
         throw new this._client.ErrorInfo(
           `Invalid object state: object state createOp map semantics=${objectState.createOp.mapCreate?.semantics}; LiveMap semantics=${this._semantics}`,
           92000,
-          500,
+          400,
         );
       }
     }
@@ -738,7 +738,7 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
       throw new this._client.ErrorInfo(
         `Cannot apply MAP_CREATE op on LiveMap objectId=${this.getObjectId()}; map's semantics=${this._semantics}, but op expected ${mapCreate?.semantics}`,
         92000,
-        500,
+        400,
       );
     }
 
@@ -781,7 +781,7 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
       throw new ErrorInfo(
         `Invalid object data for MAP_SET op on objectId=${this.getObjectId()} on key="${op.key}"`,
         92000,
-        500,
+        400,
       );
     }
 

src/plugins/liveobjects/objectid.ts

@@ -50,26 +50,26 @@ export class ObjectId {
    */
   static fromString(client: BaseClient, objectId: string | null | undefined): ObjectId {
     if (client.Utils.isNil(objectId)) {
-      throw new client.ErrorInfo('Invalid object id string', 92000, 500);
+      throw new client.ErrorInfo('Invalid object id string', 92000, 400);
     }
 
     // RTO6b1
     const [type, rest] = objectId.split(':');
     if (!type || !rest) {
-      throw new client.ErrorInfo('Invalid object id string', 92000, 500);
+      throw new client.ErrorInfo('Invalid object id string', 92000, 400);
     }
 
     if (!['map', 'counter'].includes(type)) {
-      throw new client.ErrorInfo(`Invalid object type in object id: ${objectId}`, 92000, 500);
+      throw new client.ErrorInfo(`Invalid object type in object id: ${objectId}`, 92000, 400);
     }
 
     const [hash, msTimestamp] = rest.split('@');
     if (!hash || !msTimestamp) {
-      throw new client.ErrorInfo('Invalid object id string', 92000, 500);
+      throw new client.ErrorInfo('Invalid object id string', 92000, 400);
     }
 
     if (!Number.isInteger(Number.parseInt(msTimestamp))) {
-      throw new client.ErrorInfo('Invalid object id string', 92000, 500);
+      throw new client.ErrorInfo('Invalid object id string', 92000, 400);
     }
 
     return new ObjectId(type as LiveObjectType, hash, Number.parseInt(msTimestamp));