-
Notifications
You must be signed in to change notification settings - Fork 11
47 lines (44 loc) · 2.36 KB
/
Copy pathfallow.yml
File metadata and controls
47 lines (44 loc) · 2.36 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
name: Fallow Audit (retired)
# RETIRED 2026-08-25 — superseded by the `structural-quality` job in
# build.yaml (job name "Structural Quality (blocking)", the required check).
#
# This workflow used to run the fallow structural-quality audit against a
# unit-only coverage pass it generated itself. That undercounted coverage
# for any function exercised exclusively by the integration suite (this
# repo's testing-trophy convention for services/routes — see CLAUDE.md),
# which scored those functions 0% and produced false CRAP-inflation
# findings (PR #908: 5 false findings on functions covered by 11 dedicated
# integration tests).
#
# The audit now runs inside build.yaml, fed by coverage merged from BOTH the
# unit suite (`pnpm test:coverage:check`) and the integration suite
# (`vitest --project integration --coverage`, instrumented in the existing
# "Run integration tests" step rather than run twice). See build.yaml's
# `structural-quality` job for the full audit invocation (kept verbatim in
# semantics from this file's history — same fallow flags, same PR-comment
# posting, same fail-closed exit-code handling) and its header comment for
# how the merged-coverage input is produced.
#
# `on: workflow_dispatch: {}` below exists ONLY to keep this file
# schema-valid — verified 2026-08-25 that actionlint (and GitHub Actions'
# own schema) reject a workflow with an empty or missing `on:` section
# ("on section should not be empty" / "on section is missing"), so a truly
# trigger-less file is not an option. This file is kept (not deleted; a
# repo hook blocks deletions under .github/) only so this retirement note
# is visible in the file history at its old path.
#
# workflow_dispatch means this CAN technically still be run manually from
# the Actions UI — that is harmless: the job below is named "Retired — see
# build.yaml's Structural Quality (blocking) job", not "Structural Quality
# (blocking)", so a manual run neither satisfies nor collides with the
# required check. Do not add `pull_request`/`push` triggers here — that
# would resurrect the second, coverage-blind audit this change removed.
on:
workflow_dispatch: {}
jobs:
retired:
name: Retired — see build.yaml's Structural Quality (blocking) job
runs-on: ubuntu-latest
steps:
- name: No-op
run: echo "fallow.yml is retired; the audit runs in build.yaml's structural-quality job."