Fix or suppress Psalm 6 issues

Author: trowski

psalm.xml

@@ -27,16 +27,22 @@
             </errorLevel>
         </MissingClosureReturnType>
 
+        <PossiblyUnusedMethod>
+            <errorLevel type="suppress">
+                <directory name="src"/>
+            </errorLevel>
+        </PossiblyUnusedMethod>
+
         <RedundantCastGivenDocblockType>
             <errorLevel type="suppress">
                 <directory name="src" />
             </errorLevel>
         </RedundantCastGivenDocblockType>
 
-        <RedundantConditionGivenDocblockType>
+        <UnusedClass>
             <errorLevel type="suppress">
-                <directory name="src" />
+                <directory name="src"/>
             </errorLevel>
-        </RedundantConditionGivenDocblockType>
+        </UnusedClass>
     </issueHandlers>
 </psalm>

src/Cookie/CookieAttributes.php

@@ -328,20 +328,19 @@ public function toString(): string
     {
         $string = '';
 
-        if ($this->expiry) {
+        if ($this->expiry !== null) {
             $string .= '; Expires=' . \gmdate('D, j M Y G:i:s T', $this->expiry->getTimestamp());
         }
 
-        /** @psalm-suppress RiskyTruthyFalsyComparison */
-        if ($this->maxAge) {
+        if ($this->maxAge !== null) {
             $string .= '; Max-Age=' . $this->maxAge;
         }
 
-        if ('' !== $this->path) {
+        if ($this->path !== '') {
             $string .= '; Path=' . $this->path;
         }
 
-        if ('' !== $this->domain) {
+        if ($this->domain !== '') {
             $string .= '; Domain=' . $this->domain;
         }
 

src/Cookie/ResponseCookie.php

@@ -368,7 +368,7 @@ public function withAttributes(CookieAttributes $attributes): self
     public function toString(): string
     {
         $line = $this->name . '=' . $this->value;
-        $line .= $this->attributes;
+        $line .= (string) $this->attributes;
 
         $unknownAttributes = \implode('; ', $this->unknownAttributes);
         if ($unknownAttributes !== '') {

src/Http1/Rfc7230.php

@@ -176,10 +176,12 @@ public static function formatHeaderPairs(array $headers): string
         return $bytes;
     }
 
-    // @codeCoverageIgnoreStart
+    /**
+     * @codeCoverageIgnore
+     * @psalm-suppress UnusedConstructor
+     */
     private function __construct()
     {
         // forbid instances
     }
-    // @codeCoverageIgnoreEnd
 }

src/Http2/Http2Parser.php

@@ -185,6 +185,7 @@ private function parse(?string $settings = null): \Generator
             $frameHeader = yield 9;
             $this->receivedByteCount += 9;
 
+            /** @psalm-suppress PossiblyInvalidArrayAccess */
             [
                 'length' => $frameLength,
                 'flags' => $frameFlags,
@@ -282,6 +283,7 @@ private function parsePushPromise(string $frameBuffer, int $frameLength, int $fr
 
         $padding = $isPadded ? \ord($header[0]) : 0;
 
+        /** @psalm-suppress PossiblyInvalidArrayAccess */
         $pushId = \unpack("N", $header)[1] & 0x7fffffff;
 
         if ($frameLength - $headerLength - $padding < 0) {
@@ -418,6 +420,7 @@ private function parseHeaders(string $frameBuffer, int $frameLength, int $frameF
         $padding = $isPadded ? \ord($header[0]) : 0;
 
         if ($isPriority) {
+            /** @psalm-suppress PossiblyInvalidArrayAccess */
             ['parent' => $parent, 'weight' => $weight] = \unpack("Nparent/cweight", $header, $isPadded ? 1 : 0);
 
             $parent &= 0x7fffffff;
@@ -475,9 +478,11 @@ private function parsePriorityFrame(string $frameBuffer, int $frameLength, int $
             $this->throwInvalidFrameSizeError();
         }
 
+        /** @psalm-suppress PossiblyInvalidArrayAccess */
         ['parent' => $parent, 'weight' => $weight] = \unpack("Nparent/cweight", $frameBuffer);
 
-        if ($exclusive = ($parent & 0x80000000)) {
+        $exclusive = $parent & 0x80000000;
+        if ($exclusive) {
             $parent &= 0x7fffffff;
         }
 
@@ -502,6 +507,7 @@ private function parseStreamReset(string $frameBuffer, int $frameLength, int $st
             $this->throwInvalidZeroStreamIdError();
         }
 
+        /** @psalm-suppress PossiblyInvalidArrayAccess */
         $errorCode = \unpack('N', $frameBuffer)[1];
 
         $this->handler->handleStreamReset($streamId, $errorCode);
@@ -534,6 +540,7 @@ private function parseSettings(string $frameBuffer, int $frameLength, int $frame
         $settings = [];
 
         while ($frameLength > 0) {
+            /** @psalm-suppress PossiblyInvalidArrayAccess */
             ['key' => $key, 'value' => $value] = \unpack("nkey/Nvalue", $frameBuffer);
 
             if ($value < 0) {
@@ -581,6 +588,7 @@ private function parseGoAway(string $frameBuffer, int $frameLength, int $streamI
             $this->throwInvalidNonZeroStreamIdError();
         }
 
+        /** @psalm-suppress PossiblyInvalidArrayAccess */
         ['last' => $lastId, 'error' => $error] = \unpack("Nlast/Nerror", $frameBuffer);
 
         $this->handler->handleShutdown($lastId & 0x7fffffff, $error, \substr($frameBuffer, 8));
@@ -593,6 +601,7 @@ private function parseWindowUpdate(string $frameBuffer, int $frameLength, int $s
             $this->throwInvalidFrameSizeError();
         }
 
+        /** @psalm-suppress PossiblyInvalidArrayAccess */
         $windowSize = \unpack('N', $frameBuffer)[1];
 
         if ($windowSize === 0) {

src/HttpStatus.php

@@ -178,10 +178,12 @@ public static function isServerError(int $code): bool
         return $code >= 500 && $code < 600;
     }
 
-    // @codeCoverageIgnoreStart
+    /**
+     * @codeCoverageIgnore
+     * @psalm-suppress UnusedConstructor
+     */
     private function __construct()
     {
         // forbid instances
     }
-    // @codeCoverageIgnoreEnd
 }