Merge pull request #32 from anonyein/origin

Normalize the evaluator key prior to validation

Author: anonyein

src/main/java/org/jsoup/select/QueryParser.java

@@ -345,6 +345,7 @@ private Evaluator byAttribute() {
 
     private Evaluator evaluatorForAttribute(TokenQueue cq) {
         String key = cq.consumeToAny(AttributeEvals); // eq, not, start, end, contain, match, (no val)
+        key = normalize(key);
         Validate.notEmpty(key);
         Validate.isFalse(key.equals("abs:"), "Absolute attribute key must have a name");
         cq.consumeWhitespace();

src/test/java/org/jsoup/select/SelectorTest.java

@@ -10,6 +10,8 @@
 import org.jsoup.nodes.TextNode;
 import org.jsoup.parser.Parser;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import java.util.List;
 import java.util.Locale;
@@ -1768,17 +1770,14 @@ public void testAncestorChain() {
         assertSelectedIds(doc.select("div[data*='']"), "1", "2", "3");
     }
 
-    @Test void parseExceptionOnEmptyAbsKey() {
-        // was previously firing at match time, not eval time
-        String q = "[abs:!=]";
-        boolean threw = false;
-        try {
-            Evaluator e = Selector.evaluatorOf(q);
-        } catch (Selector.SelectorParseException ex) {
-            threw = true;
-            assertEquals("Absolute attribute key must have a name", ex.getMessage());
-        }
-        assertTrue(threw);
+    @ParameterizedTest
+    @ValueSource(strings = {"[abs:!=]", "[ abs:^=]"})
+    void parseExceptionOnEmptyAbsKey(String query) {
+        Selector.SelectorParseException ex = assertThrows(
+            Selector.SelectorParseException.class,
+            () -> Selector.evaluatorOf(query)
+        );
+        assertEquals("Absolute attribute key must have a name", ex.getMessage());
     }
 
     @Test void parseExceptionOnEmptyKeyVal() {