Skip to content

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323

Open
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/remove-oidc-test-assertion
Open

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/remove-oidc-test-assertion

Conversation

@heguanhui
Copy link
Copy Markdown
Contributor

@heguanhui heguanhui commented May 17, 2026

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: AuthenticationPluginManagerTest asserts the existence of an OIDC authentication plugin (oidc), but no OIDC plugin implementation exists in the codebase. The OidcPluginFactory class referenced in AuthenticationPluginFactory.java comments is only a documentation example with no actual implementation, module, or SPI registration. This causes testPluginsAutoLoaded and testGetFactory to fail.

Release note

None

Check List (For Author)

  • Test
    • Unit Test
  • Behavior changed:
    • No.
  • Does this need documentation?
    • No.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginMana…
dd3ea8f 
…gerTest

### What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: AuthenticationPluginManagerTest asserts the existence of an OIDC authentication plugin, but no OIDC plugin implementation exists in the codebase. This causes testPluginsAutoLoaded and testGetFactory to fail.

### Release note

None

### Check List (For Author)

- Test: Unit Test
- Behavior changed: No
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 17, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui
Copy link
Copy Markdown
Contributor Author

heguanhui commented May 22, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

TPC-H: Total hot run time: 31123 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dd3ea8fef597aeb38a29f5ea1edd2ef7f89c83d8, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17618	3866	3793	3793
q2	q3	10801	1345	822	822
q4	4683	470	342	342
q5	7584	2351	2087	2087
q6	248	178	140	140
q7	934	753	641	641
q8	9361	1611	1504	1504
q9	5129	4881	4897	4881
q10	6407	2084	1779	1779
q11	427	278	240	240
q12	627	419	292	292
q13	18123	3385	2805	2805
q14	258	256	243	243
q15	q16	823	773	706	706
q17	1007	958	935	935
q18	6806	5784	5577	5577
q19	1312	1370	965	965
q20	503	403	251	251
q21	6548	2843	2795	2795
q22	469	368	325	325
Total cold run time: 99668 ms
Total hot run time: 31123 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4795	4502	4463	4463
q2	q3	4874	5305	4720	4720
q4	2120	2261	1409	1409
q5	4763	4777	4754	4754
q6	227	172	127	127
q7	1916	1786	1571	1571
q8	2412	2061	2020	2020
q9	7767	7549	7252	7252
q10	4451	4398	3949	3949
q11	517	373	345	345
q12	733	718	504	504
q13	3018	3421	2862	2862
q14	269	266	252	252
q15	q16	694	697	620	620
q17	1254	1247	1234	1234
q18	7172	6723	6652	6652
q19	1102	1090	1098	1090
q20	2215	2186	1923	1923
q21	5349	4609	4485	4485
q22	531	470	409	409
Total cold run time: 56179 ms
Total hot run time: 50641 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

TPC-DS: Total hot run time: 168966 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dd3ea8fef597aeb38a29f5ea1edd2ef7f89c83d8, data reload: false

query5	4306	667	518	518
query6	348	216	198	198
query7	4348	568	311	311
query8	323	281	222	222
query9	8808	3989	3975	3975
query10	453	339	301	301
query11	5772	2423	2262	2262
query12	183	124	124	124
query13	1287	585	446	446
query14	6105	5385	5052	5052
query14_1	4318	4321	4310	4310
query15	209	213	183	183
query16	1024	455	428	428
query17	1115	711	585	585
query18	2453	484	350	350
query19	221	194	163	163
query20	143	129	126	126
query21	220	139	120	120
query22	13599	13696	13416	13416
query23	17189	16416	15964	15964
query23_1	16054	16060	16301	16060
query24	7533	1770	1324	1324
query24_1	1283	1315	1293	1293
query25	548	482	456	456
query26	1331	322	173	173
query27	2685	582	348	348
query28	4510	1949	1951	1949
query29	1011	651	528	528
query30	307	235	200	200
query31	1114	1065	969	969
query32	87	80	77	77
query33	562	376	302	302
query34	1161	1137	657	657
query35	781	786	671	671
query36	1326	1322	1165	1165
query37	161	110	90	90
query38	3214	3168	3044	3044
query39	926	922	899	899
query39_1	897	888	881	881
query40	234	154	132	132
query41	72	72	70	70
query42	112	114	119	114
query43	339	332	285	285
query44	
query45	211	205	197	197
query46	1055	1200	721	721
query47	2308	2399	2158	2158
query48	410	435	304	304
query49	673	499	400	400
query50	1001	368	249	249
query51	4276	4337	4214	4214
query52	107	108	95	95
query53	263	285	211	211
query54	334	285	272	272
query55	95	94	89	89
query56	318	311	317	311
query57	1423	1397	1274	1274
query58	306	282	276	276
query59	1548	1632	1429	1429
query60	342	331	317	317
query61	190	180	221	180
query62	674	625	555	555
query63	237	201	199	199
query64	2383	813	622	622
query65	
query66	1716	481	356	356
query67	30152	30018	30056	30018
query68	
query69	473	345	301	301
query70	1024	973	972	972
query71	309	279	267	267
query72	3011	2683	2381	2381
query73	847	754	411	411
query74	5062	4927	4724	4724
query75	2673	2607	2234	2234
query76	2293	1145	759	759
query77	410	441	332	332
query78	12232	12074	11607	11607
query79	1429	1043	741	741
query80	630	558	437	437
query81	451	284	250	250
query82	1369	152	127	127
query83	375	274	249	249
query84	266	140	111	111
query85	881	540	439	439
query86	389	344	309	309
query87	3415	3389	3226	3226
query88	3620	2687	2632	2632
query89	442	382	330	330
query90	1884	176	179	176
query91	178	170	144	144
query92	83	78	78	78
query93	1503	1596	965	965
query94	534	359	326	326
query95	664	382	347	347
query96	1016	862	323	323
query97	2710	2678	2573	2573
query98	238	229	251	229
query99	1161	1075	990	990
Total cold run time: 253270 ms
Total hot run time: 168966 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

FE Regression Coverage Report

Increment line coverage 0.00% (0/31) 🎉
Increment coverage report
Complete coverage report

@heguanhui
Copy link
Copy Markdown
Contributor Author

heguanhui commented May 22, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

TPC-H: Total hot run time: 31331 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dd3ea8fef597aeb38a29f5ea1edd2ef7f89c83d8, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17714	3956	3987	3956
q2	q3	10744	1377	794	794
q4	4682	472	338	338
q5	7532	2248	2072	2072
q6	268	182	143	143
q7	910	746	633	633
q8	9358	1751	1625	1625
q9	6542	4864	4921	4864
q10	6435	2086	1794	1794
q11	435	269	242	242
q12	687	436	304	304
q13	18205	3405	2788	2788
q14	274	256	250	250
q15	q16	817	761	708	708
q17	937	889	923	889
q18	7030	5718	5532	5532
q19	1180	1332	1184	1184
q20	593	422	289	289
q21	5924	2820	2603	2603
q22	473	366	323	323
Total cold run time: 100740 ms
Total hot run time: 31331 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4787	4614	4810	4614
q2	q3	4867	5208	4590	4590
q4	2212	2315	1461	1461
q5	4889	4613	4718	4613
q6	231	184	142	142
q7	1886	1712	1469	1469
q8	2198	2030	1943	1943
q9	7206	7155	7159	7155
q10	4462	4385	3967	3967
q11	542	421	355	355
q12	716	718	515	515
q13	3051	3378	2764	2764
q14	272	279	255	255
q15	q16	688	704	616	616
q17	1259	1256	1253	1253
q18	7237	6843	6873	6843
q19	1116	1060	1056	1056
q20	2196	2209	1939	1939
q21	5360	4709	4532	4532
q22	523	455	410	410
Total cold run time: 55698 ms
Total hot run time: 50492 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

TPC-DS: Total hot run time: 168998 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dd3ea8fef597aeb38a29f5ea1edd2ef7f89c83d8, data reload: false

query5	4318	647	524	524
query6	337	221	198	198
query7	4241	563	318	318
query8	328	235	214	214
query9	8828	4010	4007	4007
query10	465	336	299	299
query11	5832	2389	2221	2221
query12	179	127	137	127
query13	1262	590	438	438
query14	5947	5378	5055	5055
query14_1	4375	4346	4337	4337
query15	211	203	186	186
query16	1040	452	436	436
query17	945	726	581	581
query18	2479	479	357	357
query19	212	206	179	179
query20	135	129	124	124
query21	241	137	116	116
query22	13576	13543	13415	13415
query23	17150	16382	16016	16016
query23_1	16139	16052	16084	16052
query24	7452	1765	1305	1305
query24_1	1312	1264	1292	1264
query25	549	489	409	409
query26	1307	342	174	174
query27	2659	554	331	331
query28	4493	1949	1935	1935
query29	978	640	495	495
query30	311	226	199	199
query31	1123	1064	936	936
query32	89	78	78	78
query33	553	367	300	300
query34	1173	1146	656	656
query35	784	790	688	688
query36	1318	1325	1199	1199
query37	185	111	95	95
query38	3268	3149	3093	3093
query39	934	910	883	883
query39_1	882	885	878	878
query40	229	154	134	134
query41	74	68	67	67
query42	115	119	112	112
query43	325	330	294	294
query44	
query45	214	202	196	196
query46	1066	1228	707	707
query47	2299	2260	2160	2160
query48	419	412	308	308
query49	661	516	406	406
query50	978	350	269	269
query51	4353	4308	4283	4283
query52	105	110	97	97
query53	265	294	212	212
query54	351	296	292	292
query55	96	94	92	92
query56	334	337	349	337
query57	1485	1427	1343	1343
query58	313	284	289	284
query59	1605	1687	1427	1427
query60	345	343	343	343
query61	184	190	192	190
query62	673	616	564	564
query63	248	207	221	207
query64	2473	863	701	701
query65	
query66	1759	484	367	367
query67	29993	29904	29861	29861
query68	
query69	462	356	307	307
query70	1015	964	1002	964
query71	316	284	272	272
query72	3118	2684	2384	2384
query73	834	770	418	418
query74	5055	4907	4693	4693
query75	2666	2564	2263	2263
query76	2279	1141	755	755
query77	395	404	329	329
query78	12142	12113	11556	11556
query79	1483	1085	722	722
query80	1287	548	485	485
query81	527	279	238	238
query82	995	162	118	118
query83	327	273	251	251
query84	316	142	111	111
query85	955	533	452	452
query86	455	341	354	341
query87	3404	3397	3233	3233
query88	3578	2670	2681	2670
query89	451	382	336	336
query90	1911	178	178	178
query91	182	167	143	143
query92	75	82	78	78
query93	1675	1392	918	918
query94	721	352	299	299
query95	675	476	340	340
query96	991	789	349	349
query97	2686	2672	2536	2536
query98	236	229	233	229
query99	1142	1103	981	981
Total cold run time: 253593 ms
Total hot run time: 168998 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 22, 2026

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heguanhui @hello-stephen