[fix](be) Disable dict encoding for row store columns#63441
Open
eldenmoon wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Row store columns contain serialized row data and should stay on plain pages. Dictionary encoding can introduce dictionary pages for the hidden row store column, so force row store column metadata to use the configured plain binary encoding.
### Release note
Fix row store columns to use plain encoding instead of dictionary encoding.
### Check List (For Author)
- Test:
- Unit Test: ./run-be-ut.sh --run --filter='ColumnMetaAccessorTest.RowStoreColumnDoesNotUseDictEncoding'
- Manual test: build-support/check-format.sh
- Behavior changed: Yes. Hidden row store columns now use plain encoding instead of dictionary encoding.
- Does this need documentation: No
Member
Author
|
run buildall |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes BE segment writing for the hidden row-store column (__DORIS_ROW_STORE_COL__) by explicitly forcing plain binary encoding for that column, preventing dictionary encoding from introducing dictionary pages for already-serialized row blobs.
Changes:
- Force row-store column
ColumnMetaPB.encodingtoPLAIN_ENCODING/PLAIN_ENCODING_V2(based onTabletSchema::binary_plain_encoding_default_impl()), in bothSegmentWriterandVerticalSegmentWriter. - Add a BE unit test that builds a real segment containing a row-store column and asserts its footer metadata encoding is plain (not dict).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
be/src/storage/segment/segment_writer.cpp |
Forces row-store column metadata encoding to plain when creating the column writer. |
be/src/storage/segment/vertical_segment_writer.cpp |
Mirrors the same row-store encoding override in the vertical writer path. |
be/test/storage/segment/column_meta_accessor_test.cpp |
Adds a segment-build regression test asserting row-store column footer encoding is plain (v2). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
TPC-H: Total hot run time: 31081 ms |
Contributor
TPC-DS: Total hot run time: 169417 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Row store columns contain serialized row data and should stay on plain pages. Dictionary encoding can introduce dictionary pages for the hidden row store column, so force row store column metadata to use the configured plain binary encoding.
Release note
Fix row store columns to use plain encoding instead of dictionary encoding.
Check List (For Author)