[followup](BE) rename assume_mutable to assert_mutable#63557
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31496 ms |
Contributor
TPC-DS: Total hot run time: 172016 ms |
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No blocking issues found. The PR is a focused mechanical rename of the COW API from assume_mutable* to assert_mutable*, with matching call-site, test, and BE core review-guide updates. I also verified there are no remaining assume_mutable references in tracked source files and git diff --check is clean.
Critical checkpoint conclusions:
- Goal/test: The rename matches the stated goal; existing COW ownership test was updated to the new API name.
- Scope: The change is small and focused; no behavioral change beyond diagnostics/name.
- Concurrency/lifecycle/config/compatibility: No new concurrency, lifecycle, configuration, storage format, or protocol compatibility concerns introduced.
- Parallel paths: Call sites across BE source and tests appear consistently renamed; no old API references remain in source.
- Error handling/data correctness/memory: The ownership assertion behavior is preserved, including throwing on shared ownership; no new memory ownership or data visibility changes.
- Tests: No new tests are needed for this mechanical rename; the existing COW exclusivity test remains present under the new API.
- Observability/performance: No runtime observability or performance impact expected.
User focus: No additional user-provided review focus was specified.
Mryange
approved these changes
May 23, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup #63001. we changed the actual meaning of
assume_mutable