REST: Add metadata_location to View, and register_view integration test

Author: ebyhr

pyiceberg/catalog/rest/__init__.py

@@ -851,6 +851,7 @@ def _response_to_staged_table(self, identifier_tuple: tuple[str, ...], table_res
     def _response_to_view(self, identifier_tuple: tuple[str, ...], view_response: ViewResponse) -> View:
         return View(
             identifier=identifier_tuple,
+            metadata_location=view_response.metadata_location,
             metadata=view_response.metadata,
         )
 

pyiceberg/view/__init__.py

@@ -29,14 +29,17 @@ class View:
 
     _identifier: Identifier
     metadata: ViewMetadata
+    metadata_location: str | None
 
     def __init__(
         self,
         identifier: Identifier,
         metadata: ViewMetadata,
+        metadata_location: str | None = None,
     ) -> None:
         self._identifier = identifier
         self.metadata = metadata
+        self.metadata_location = metadata_location
 
     def name(self) -> Identifier:
         """Return the identifier of this view."""

tests/conftest.py

@@ -2473,6 +2473,8 @@ def clean_up(test_catalog: Catalog) -> None:
         if "my_iceberg_database-" in database_name:
             for identifier in test_catalog.list_tables(database_name):
                 test_catalog.drop_table(identifier)
+            for identifier in test_catalog.list_views(database_name):
+                test_catalog.drop_view(identifier)
             test_catalog.drop_namespace(database_name)
 
 

tests/integration/test_catalog.py

@@ -44,6 +44,7 @@
 from pyiceberg.table.sorting import INITIAL_SORT_ORDER_ID, SortField, SortOrder
 from pyiceberg.transforms import BucketTransform, DayTransform, IdentityTransform
 from pyiceberg.types import IntegerType, LongType, NestedField, TimestampType, UUIDType
+from pyiceberg.view.metadata import SQLViewRepresentation, ViewVersion
 from tests.conftest import (
     clean_up,
     does_support_atomic_concurrent_updates,
@@ -617,6 +618,36 @@ def test_register_table_existing(test_catalog: Catalog, table_schema_nested: Sch
         test_catalog.register_table(identifier, metadata_location=table.metadata_location)
 
 
+@pytest.mark.integration
+def test_rest_register_view(rest_catalog: RestCatalog, table_schema_simple: Schema, database_name: str, view_name: str) -> None:
+    identifier = (database_name, view_name)
+
+    rest_catalog.create_namespace_if_not_exists(database_name)
+
+    view_version = ViewVersion(
+        version_id=1,
+        schema_id=1,
+        timestamp_ms=1,
+        summary={},
+        representations=[
+            SQLViewRepresentation(
+                type="sql",
+                sql="SELECT 1 as some_col",
+                dialect="spark",
+            )
+        ],
+        default_namespace=["default"],
+    )
+
+    view = rest_catalog.create_view(identifier, table_schema_simple, view_version)
+    assert rest_catalog.view_exists(identifier)
+
+    register_identifier = (database_name, "register_identifier")
+    assert not rest_catalog.view_exists(register_identifier)
+    rest_catalog.register_view(register_identifier, view.metadata_location)
+    assert rest_catalog.view_exists(register_identifier)
+
+
 @pytest.mark.integration
 def test_rest_custom_namespace_separator(rest_catalog: RestCatalog, table_schema_simple: Schema) -> None:
     """