Skip to content

Commit e486985

Browse files
authored
REST: Allow Identifier type in drop_view method (#3408)
# Rationale for this change Fix the warning message in the IDE. The base class and other classes use the `str | Identifier` style in the `drop_view` method. I also confirmed that other methods in the REST catalog class use `str | Identifier` for identifiers. ## Are these changes tested? N/A ## Are there any user-facing changes? No <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 8055a60 commit e486985

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pyiceberg/catalog/rest/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1461,7 +1461,7 @@ def register_view(self, identifier: str | Identifier, metadata_location: str) ->
14611461

14621462
@retry(**_RETRY_ARGS)
14631463
@override
1464-
def drop_view(self, identifier: str) -> None:
1464+
def drop_view(self, identifier: str | Identifier) -> None:
14651465
self._check_endpoint(Capability.V1_DELETE_VIEW)
14661466
response = self._session.delete(
14671467
self.url(Endpoints.drop_view, prefixed=True, **self._split_identifier_for_path(identifier, IdentifierKind.VIEW)),

0 commit comments

Comments
 (0)