[2.x] Undo GAV changes - #8
Conversation
The top level G is `org.apache.maven.executor` and everything except for maven-executor-plugin is there.
|
such parent POM artifactId will publish "executor" is not really a name that is very Maven specific |
| ExecutorRequest.mavenBuilder() | ||
| .userHomeDirectory(ExecutorRequest.discoverUserHomeDirectory()) | ||
| .build()) | ||
| .mavenVersion()); |
There was a problem hiding this comment.
how is that change related to "undo GAV change"?
| <groupId>org.apache.maven</groupId> | ||
| <artifactId>maven-parent</artifactId> | ||
| <version>47</version> | ||
| <version>48</version> |
There was a problem hiding this comment.
not related to "Undo GAV change"
There was a problem hiding this comment.
Yes, upped parent too (hence reformat as well,due spotless changes)
There was a problem hiding this comment.
"upped parent" = "undo GAV change"?
I know it's 1 line, but not the same intent, definitively
But is very same as enforcer does: |
|
Also, Maybe we need some changes then to our source bundle creation? |
true, but my personal opinion is that "enforcer" is less vague than "executor", and I can't change the past, just trying to have clear future
the question is just about the file name being based on artifactId: whatever bundle creation approach you take, you'll have the same |
too late to avoid it |
Yes, as this project was part of maven 4 project, and |
past releases won't cease to exist in Maven Central: I really don't see what you want to avoid by not continuing to use the existing coordinate in Maven Central |
|
Simple: I don't want to distinct projects produce same GAs. That is wrong thing to do and exactly due non-removal policy, is way for more trouble |
|
What about a middle ground: keep the groupId change to <groupId>org.apache.maven.executor</groupId>
<artifactId>maven-executor</artifactId>This would:
Claude Code on behalf of Guillaume Nodet |
|
Q1: any proposal then, how to name the |
|
I see two ways forward: Solution 1 — Keep the project name as-is, but use <groupId>org.apache.maven.executor</groupId>
<artifactId>maven-executor-parent</artifactId>
Solution 2 — Rename the project to something less vague If the real issue is that "executor" on its own is too generic, we could rename the project. That would let the
Claude Code on behalf of Guillaume Nodet |
|
Fwiw, I'm also fine with using |
|
do as you wish: I don't want to loose more time on getting Maven 4 out, I can do compromises, not worth discussing for months |
Thanks @hboutemy and I agree with your target. |
3 participants
The top level G is
org.apache.maven.executorand everything except for maven-executor-plugin is there.At the same time update parent POM to 48.
Wanted layout is:
