fix: handle || operator and remove & from X= lookahead

Address review feedback from gnodet on PR #12038:
- Remove c == '&' from the >=/<= /==/!= lookahead (&= is not valid)
- Add || tokenization symmetrically with &&
- Add regression tests for || with line breaks

Fixes #11882

Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>

Author: blaspat

impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/ConditionParser.java

@@ -129,21 +129,33 @@ private List<String> tokenize(String expression) {
                 }
                 quoteType = c;
                 sb.append(c);
-            } else if (Character.isWhitespace(c) || c == '(' || c == ')' || c == ',' || c == '+'
-                    || c == '>' || c == '<' || c == '=' || c == '!' || c == '&' || c == '|') {
+            } else if (Character.isWhitespace(c)
+                    || c == '('
+                    || c == ')'
+                    || c == ','
+                    || c == '+'
+                    || c == '>'
+                    || c == '<'
+                    || c == '='
+                    || c == '!'
+                    || c == '&'
+                    || c == '|') {
                 if (!sb.isEmpty()) {
                     tokens.add(sb.toString());
                     sb.setLength(0);
                 }
                 if (!Character.isWhitespace(c)) {
-                    if ((c == '>' || c == '<' || c == '=' || c == '!' || c == '&')
+                    if ((c == '>' || c == '<' || c == '=' || c == '!')
                             && i + 1 < expression.length()
                             && expression.charAt(i + 1) == '=') {
                         tokens.add(c + "=");
                         i++; // Skip the next character
                     } else if (c == '&' && i + 1 < expression.length() && expression.charAt(i + 1) == '&') {
                         tokens.add("&&");
                         i++; // Skip the next character
+                    } else if (c == '|' && i + 1 < expression.length() && expression.charAt(i + 1) == '|') {
+                        tokens.add("||");
+                        i++; // Skip the next character
                     } else {
                         tokens.add(String.valueOf(c));
                     }

impl/maven-impl/src/test/java/org/apache/maven/impl/model/profile/ConditionParserTest.java

@@ -287,6 +287,29 @@ void testAmpersandAmpersandTokenizerMultiline() {
                 (Boolean) parser.parse("${os.arch} == 'amd64'\n&& ${os.name} == 'windows' && ${os.name} == 'windows'"));
     }
 
+    @Test
+    void testPipePipeTokenizerMultiline() {
+        // Regression test for https://github.com/apache/maven/issues/11882
+        // The || operator was not being tokenized correctly when a line break appeared before it.
+        // Uses ${os.name} which is set to 'windows' in the mock context.
+
+        // Case 1: Basic || without line breaks (baseline)
+        assertTrue((Boolean) parser.parse("${os.arch} == 'amd64' || ${os.name} == 'windows'"));
+
+        // Case 2: Line break BEFORE ||
+        assertTrue((Boolean) parser.parse("${os.arch} == 'amd64'\n|| ${os.name} == 'windows'"));
+
+        // Case 3: Line break AFTER ||
+        assertTrue((Boolean) parser.parse("${os.arch} == 'amd64' ||\n${os.name} == 'windows'"));
+
+        // Case 4: Line breaks on both sides
+        assertTrue((Boolean) parser.parse("${os.arch} == 'amd64'\n||\n${os.name} == 'windows'"));
+
+        // Case 5: Mixed && and || with line breaks
+        assertTrue(
+                (Boolean) parser.parse("${os.arch} == 'amd64'\n&& ${os.name} == 'windows' || ${os.name} == 'windows'"));
+    }
+
     @Test
     void testNestedPropertyAlias() {
         functions.put("property", args -> {