Crypto se05x drivers #37
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
9m 23s
Annotations
19 errors and 10 warnings
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
Nits.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Please remove blank lines at start of 'drivers/crypto/Kconfig.se05x'
|
|
Run compliance checks on patch series (PR):
ModulesMaintainers.txt#L0
Check that all modules have a MAINTAINERS entry.
Missing MAINTAINERS.yml entry for: "West project: plugandtrust"
|
|
Run compliance checks on patch series (PR):
KeepSorted.txt#L0
Check for blocks of code or config that should be kept sorted.
KeepSorted:sorted block has out-of-order line at 318
File:west.yml
Line:379
|
|
Run compliance checks on patch series (PR):
KconfigBasicNoModules.txt#L0
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Undefined Kconfig symbols:
warning: undefined symbol TINYCRYPT_AES_CB:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_AES_CM:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_CTR_PR:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_ECC_DS:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
Boolean option 'PLUGANDTRUST_SCP03' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean option 'PLUGANDTRUST_ECKEY' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean option 'PLUGANDTRUST_ECKEY_SCP03' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean option 'PLUGANDTRUST_SM_APDU_MUTEX' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean option 'PLUGANDTRUST_SCP03' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean option 'PLUGANDTRUST_ECKEY' prompt must not start with 'Enable...'. Please
check Kconfig guidelines.
Boolean
|
|
Run compliance checks on patch series (PR):
Kconfig.txt#L0
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Undefined Kconfig symbols:
warning: undefined symbol TINYCRYPT_AES_CB:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_AES_CM:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_CTR_PR:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST
help
This option enables secure channel for SE05x.
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_ECC_DH
depends on PLUGANDTRUST && 0
help
This option enables secure channel for SE05x.
warning: undefined symbol TINYCRYPT_ECC_DS:
- Referenced at modules/plugandtrust/Kconfig:12:
config PLUGANDTRUST_SCP03
bool "Enable secure channel for SE05x"
select TINYCRYPT
select TINYCRYPT_AES
select TINYCRYPT_AES_CB
select TINYCRYPT_AES_CM
select TINYCRYPT_CTR_PR
select TINYCRYPT_ECC_DS
select TINYCRYPT_SHA256
select TINYCRYPT_E
|
|
Run compliance checks on patch series (PR):
Identity.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
7e5e48aacb157157d3aaedab0c59f5beb02d2c4f: Missing signed-off-by line
232e617be814ce44b87167615315145d063cd09a: Missing signed-off-by line
7b0797451340f64b67ca4010a7b92611ffc0b477: Missing signed-off-by line
|
|
Run compliance checks on patch series (PR):
Gitlint.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
WARNING: I4 - ignore-by-author-name: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-by-author-name.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
Commit 7e5e48aacb:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
Commit 232e617be8:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
Commit 7b07974513:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
|
|
Run compliance checks on patch series (PR):
Checkpatch.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
POINTER_LOCATION: "(foo*)" should be "(foo *)"
File:drivers/crypto/crypto_se05x.c
Line:23
POINTER_LOCATION: "(foo*)" should be "(foo *)"
File:drivers/crypto/crypto_se05x.c
Line:61
ASSIGN_IN_IF: do not use assignment in if condition
File:drivers/crypto/crypto_se05x.c
Line:64
POINTER_LOCATION: "(foo*)" should be "(foo *)"
File:drivers/crypto/crypto_se05x.c
Line:75
ASSIGN_IN_IF: do not use assignment in if condition
File:drivers/crypto/crypto_se05x.c
Line:78
LINE_SPACING: Missing a blank line after declarations
File:drivers/crypto/crypto_se05x.c
Line:119
LONG_LINE: line length of 127 exceeds 100 columns
File:modules/plugandtrust/sm_i2c.h
Line:40
LONG_LINE: line length of 126 exceeds 100 columns
File:modules/plugandtrust/sm_i2c.h
Line:41
C99_COMMENTS: do not use C99 // comments
File:modules/plugandtrust/sm_i2c.h
Line:47
C99_COMMENTS: do not use C99 // comments
File:modules/plugandtrust/sm_port.h
Line:48
BLOCK_COMMENT_STYLE: Block comments should align the * on each line
File:modules/plugandtrust/sm_timer.c
Line:9
BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
File:modules/plugandtrust/sm_timer.c
Line:26
FUNCTION_WITHOUT_ARGS: Bad function definition - uint32_t sm_initSleep() should probably be uint32_t sm_initSleep(void)
File:modules/plugandtrust/sm_timer.c
Line:27
LEADING_SPACE: please, no spaces at the start of a line
File:modules/plugandtrust/sm_timer.c
Line:29
LEADING_SPACE: please, no spaces at the start of a line
File:modules/plugandtrust/sm_timer.c
Line:37
LEADING_SPACE: please, no spaces at the start of a line
File:modules/plugandtrust/sm_timer.c
Line:45
TYPO_SPELLING: 'Funtion' may be misspelled - perhaps 'Function'?
File:modules/plugandtrust/sm_timer.h
Line:14
C99_COMMENTS: do not use C99 // comments
File:modules/plugandtrust/sm_timer.h
Line:29
|
|
KeepSorted:
west.yml#L379
west.yml:379 sorted block has out-of-order line at 318
|
|
C99_COMMENTS:
modules/plugandtrust/sm_timer.h#L29
modules/plugandtrust/sm_timer.h:29 do not use C99 // comments
|
|
FUNCTION_WITHOUT_ARGS:
modules/plugandtrust/sm_timer.c#L27
modules/plugandtrust/sm_timer.c:27 Bad function definition - uint32_t sm_initSleep() should probably be uint32_t sm_initSleep(void)
|
|
C99_COMMENTS:
modules/plugandtrust/sm_port.h#L48
modules/plugandtrust/sm_port.h:48 do not use C99 // comments
|
|
C99_COMMENTS:
modules/plugandtrust/sm_i2c.h#L47
modules/plugandtrust/sm_i2c.h:47 do not use C99 // comments
|
|
ASSIGN_IN_IF:
drivers/crypto/crypto_se05x.c#L78
drivers/crypto/crypto_se05x.c:78 do not use assignment in if condition
|
|
POINTER_LOCATION:
drivers/crypto/crypto_se05x.c#L75
drivers/crypto/crypto_se05x.c:75 "(foo*)" should be "(foo *)"
|
|
ASSIGN_IN_IF:
drivers/crypto/crypto_se05x.c#L64
drivers/crypto/crypto_se05x.c:64 do not use assignment in if condition
|
|
POINTER_LOCATION:
drivers/crypto/crypto_se05x.c#L61
drivers/crypto/crypto_se05x.c:61 "(foo*)" should be "(foo *)"
|
|
POINTER_LOCATION:
drivers/crypto/crypto_se05x.c#L23
drivers/crypto/crypto_se05x.c:23 "(foo*)" should be "(foo *)"
|
|
Run compliance checks on patch series (PR)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683, actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065, actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
TYPO_SPELLING:
modules/plugandtrust/sm_timer.h#L14
modules/plugandtrust/sm_timer.h:14 'Funtion' may be misspelled - perhaps 'Function'?
|
|
LEADING_SPACE:
modules/plugandtrust/sm_timer.c#L45
modules/plugandtrust/sm_timer.c:45 please, no spaces at the start of a line
|
|
LEADING_SPACE:
modules/plugandtrust/sm_timer.c#L37
modules/plugandtrust/sm_timer.c:37 please, no spaces at the start of a line
|
|
LEADING_SPACE:
modules/plugandtrust/sm_timer.c#L29
modules/plugandtrust/sm_timer.c:29 please, no spaces at the start of a line
|
|
BLOCK_COMMENT_STYLE:
modules/plugandtrust/sm_timer.c#L26
modules/plugandtrust/sm_timer.c:26 Block comments use a trailing */ on a separate line
|
|
BLOCK_COMMENT_STYLE:
modules/plugandtrust/sm_timer.c#L9
modules/plugandtrust/sm_timer.c:9 Block comments should align the * on each line
|
|
LONG_LINE:
modules/plugandtrust/sm_i2c.h#L41
modules/plugandtrust/sm_i2c.h:41 line length of 126 exceeds 100 columns
|
|
LONG_LINE:
modules/plugandtrust/sm_i2c.h#L40
modules/plugandtrust/sm_i2c.h:40 line length of 127 exceeds 100 columns
|
|
LINE_SPACING:
drivers/crypto/crypto_se05x.c#L119
drivers/crypto/crypto_se05x.c:119 Missing a blank line after declarations
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
compliance.xml
|
2.47 KB |
sha256:749a3bcd98bd981b330515425051154a0de0a5a3f844629a4241f4beed59a476
|
|