Commit 2979199
committed
revert(b20-mock): drop isAnnouncementActive view and transient flag
The previous commit added an isAnnouncementActive() view backed by an
EIP-1153 transient flag, aiming for parity with the Rust precompile's
is_announcement_active runtime flag. On review the check is unnecessary:
inner-call dispatch in announce(...) is self-delegatecall only, so there
is no reentrancy surface for an external contract to want to detect a
bracket-in-progress against.
Removes the view from IB20Asset, the flag and its set/clear from
MockB20Asset.announce, and the boundary tests.1 parent ea1b5b0 commit 2979199
3 files changed
Lines changed: 0 additions & 105 deletions
File tree
- src/interfaces
- test
- lib/mocks
- unit/B20Asset/announcement
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | 112 | | |
127 | 113 | | |
128 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | 67 | | |
90 | 68 | | |
91 | 69 | | |
| |||
119 | 97 | | |
120 | 98 | | |
121 | 99 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | 100 | | |
130 | 101 | | |
131 | 102 | | |
| |||
135 | 106 | | |
136 | 107 | | |
137 | 108 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 109 | | |
144 | 110 | | |
145 | 111 | | |
146 | 112 | | |
147 | 113 | | |
148 | 114 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | 115 | | |
154 | 116 | | |
155 | 117 | | |
| |||
Lines changed: 0 additions & 53 deletions
This file was deleted.
0 commit comments