Skip to content

Fix chats archive/unarchive hitting the wrong endpoint (silent no-op) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malob wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

Fix chats archive/unarchive hitting the wrong endpoint (silent no-op) #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/fix-chats-archive-endpoint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@beeper/cli': patch
---

Fix `chats archive` and `chats unarchive` silently no-op'ing.

Both commands called the generic chat-update endpoint (`PATCH /v1/chats/{chatID}`
with `{ isArchived }`), which returns `200 OK` but ignores `isArchived` — so the
command reported success while the chat was never archived or unarchived. They now
call the dedicated archive endpoint (`archiveChat`: `POST /v1/chats/{chatID}/archive`
with `{ archived }`) via `client.chats.archive(chatID, { archived })`, so the chat's
archive state actually changes.
3 changes: 2 additions & 1 deletion packages/cli/src/commands/chats/archive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default class ChatsArchive extends BeeperCommand {

const client = await createClient(flags)
const chatID = await resolveChatID(client, flags.chat, { pick: flags.pick })
await printData(await client.chats.update(chatID, { isArchived: true }), flags.json ? 'json' : 'human')
await client.chats.archive(chatID, { archived: true })
await printSuccess({ message: 'Chat archived', data: { chatID, archived: true } }, flags.json ? 'json' : 'human')
}
}
3 changes: 2 additions & 1 deletion packages/cli/src/commands/chats/unarchive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default class ChatsUnarchive extends BeeperCommand {

const client = await createClient(flags)
const chatID = await resolveChatID(client, flags.chat, { pick: flags.pick })
await printData(await client.chats.update(chatID, { isArchived: false }), flags.json ? 'json' : 'human')
await client.chats.archive(chatID, { archived: false })
await printSuccess({ message: 'Chat unarchived', data: { chatID, archived: false } }, flags.json ? 'json' : 'human')
}
}