Skip to content

Commit 357485a

Browse files
authored
fix: align workflow preset integration assertions
Validate workflow-preset tasks-template via core resolution instead of asserting a preset-owned template file.
1 parent 01edaaa commit 357485a

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/workflow-preset-integration.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,13 @@ jobs:
110110
grep -F "plan-template" preset-resolve-plan-template.txt
111111
grep -F "workflow-preset" preset-resolve-plan-template.txt
112112
113+
/tmp/specify-workflow-preset-venv/bin/specify preset resolve tasks-template | tee preset-resolve-tasks-template.txt
114+
grep -F "tasks-template" preset-resolve-tasks-template.txt
115+
grep -F "(top layer from: core)" preset-resolve-tasks-template.txt
116+
113117
test -f .specify/presets/workflow-preset/preset.yml
114118
test -f .specify/presets/workflow-preset/templates/plan-template.md
115-
test -f .specify/presets/workflow-preset/templates/tasks-template.md
119+
test -f .specify/templates/tasks-template.md
116120
test -f .specify/presets/workflow-preset/commands/speckit.plan.md
117121
test -f .specify/presets/workflow-preset/commands/speckit.tasks.md
118122
test -f .specify/presets/workflow-preset/commands/speckit.implement.md

tests/test_presets.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3518,6 +3518,10 @@ def test_workflow_preset_integration_release_payload_contract(self):
35183518
) in workflow_text
35193519
assert "^[0-9]+\\.[0-9]+\\.[0-9]+$" in workflow_text
35203520
assert "/workflow-preset.zip" not in workflow_text
3521+
assert "test -f .specify/presets/workflow-preset/templates/tasks-template.md" not in workflow_text
3522+
assert "specify preset resolve tasks-template" in workflow_text
3523+
assert 'grep -F "(top layer from: core)" preset-resolve-tasks-template.txt' in workflow_text
3524+
assert "test -f .specify/templates/tasks-template.md" in workflow_text
35213525

35223526
def test_bundled_preset_download_raises_error(self, project_dir):
35233527
"""download_pack raises PresetError for bundled presets without download_url."""

0 commit comments

Comments
 (0)