upgrade

Author: mxmpl

.github/workflows/release.yml

@@ -82,22 +82,10 @@ jobs:
           version: "latest"
           enable-cache: false
 
-      - name: Install dependencies on Linux and Windows
-        if: runner.os != 'macOS'
-        run: |
-          uv venv
-          uv pip install setuptools numpy ninja
-          uv pip install torch --index-url https://download.pytorch.org/whl/nightly/cu128
-
-      - name: Install dependencies on macOS
-        if: runner.os == 'macOS'
-        run: |
-          uv venv
-          uv pip install setuptools numpy ninja
-          uv pip install torch --index-url https://download.pytorch.org/whl/nightly/cpu
-
       - name: Build wheel
-        run: uv build --wheel --no-build-isolation
+        env:
+          TORCH_CUDA_ARCH_LIST: "7.0;7.5;8.0;8.6;9.0;10.0;12.0+PTX"
+        run: uv build --wheel
 
       - name: Relabel the Linux wheel
         if: runner.os == 'Linux'

.gitignore

@@ -10,5 +10,4 @@ dist
 __pycache__
 .python-version
 *.so
-uv.lock
 .vscode

pyproject.toml

@@ -9,6 +9,18 @@ authors = [
   { name = "CoML", email = "dev@cognitive-ml.fr" },
 ]
 keywords = ["machine learning"]
+classifiers = [
+  "Development Status :: 4 - Beta",
+  "Intended Audience :: Science/Research",
+  "Operating System :: OS Independent",
+  "Programming Language :: C++",
+  "Programming Language :: Python :: 3 :: Only",
+  "Programming Language :: Python :: 3.12",
+  "Programming Language :: Python :: 3.13",
+  "Programming Language :: Python :: 3.14",
+  "Topic :: Scientific/Engineering",
+  "Topic :: Scientific/Engineering :: Artificial Intelligence",
+]
 dependencies = [
   "torch>=2.10.0",
 ]
@@ -44,6 +56,7 @@ line-length = 119
 select = ["ALL"]
 ignore = [
   "COM812",  # missing-trailing-comma
+  "D107",  # undocumented-public-init
   "D203",  # incorrect-blank-line-before-class
   "D213",  # multi-line-summary-second-line
   "N803",  # invalid-argument-name

setup.py

@@ -19,11 +19,22 @@ def get_flags() -> tuple[list[str], list[str]]:
     raise RuntimeError(sys.platform)
 
 
+class CUDAArchListError(RuntimeError):
+    """To raise if CUDA is found and TORCH_CUDA_ARCH_LIST is not set."""
+
+    def __init__(self) -> None:
+        super().__init__(
+            "You must explicitly set TORCH_CUDA_ARCH_LIST to build from source if CUDA is found.\n"
+            "Check you supported gpu architectures beforehand.\n"
+            "For example: TORCH_CUDA_ARCH_LIST='7.0;7.5;8.0;8.6;9.0;10.0;12.0+PTX'"
+        )
+
+
 def get_extension() -> Extension:
     """Either CUDA or CPU extension."""
-    if "TORCH_CUDA_ARCH_LIST" not in os.environ:
-        os.environ["TORCH_CUDA_ARCH_LIST"] = "7.0;7.5;8.0;8.6;9.0;10.0;12.0+PTX"
     use_cuda = CUDA_HOME is not None
+    if use_cuda and "TORCH_CUDA_ARCH_LIST" not in os.environ:
+        raise CUDAArchListError
     extension = CUDAExtension if use_cuda else CppExtension
     sources = ["src/torchdtw/csrc/dtw.cpp"] + (["src/torchdtw/csrc/cuda/dtw.cu"] if use_cuda else [])
     compiler_flags, linker_flags = get_flags()