Skip to content

Commit b9e9f74

Browse files
rsc3claude
andcommitted
Add Plumbing tests using Allen's own MapMyCells example files
Fetched from https://brain-map.org/bkp/analyze/mapmycells/files (verified both URLs resolve): a 1k-cell human MTG example and a 10k-cell whole-mouse- brain example, both small enough for a fast/cheap smoke test. Staged at gs://pd-test-storage-public/MapMyCells/input/plumbing/{human,mouse}/, matching the <Pipeline>/input/{plumbing,scientific}/ layout other WARP pipelines use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent d8693f0 commit b9e9f74

4 files changed

Lines changed: 17 additions & 2 deletions

File tree

pipelines/wdl/mapmycells/MapMyCells.changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@
1010
* Repointed `test_inputs/Plumbing/test_human.json` and `test_mouse.json` at real, existing gene-expression h5ads borrowed from the scANVI pipeline's own test set (`10k_PBMC_gex.h5ad`, `Mouse_Hippocampus_AIT_plumbing_gex.h5ad`) instead of `query.h5ad`/`query_mouse.h5ad`, which never existed; MapMyCells only consumes gene expression, so only the gex file from each scANVI test case is reused, not the ATAC or reference h5ads
1111
* Added a Citing section to the README crediting the Allen Institute's `cell_type_mapper` (source code + the MapMyCells preprint, Daniel et al. 2026, bioRxiv doi:10.64898/2026.03.06.710160)
1212
* Moved `test_human.json`/`test_mouse.json` from `test_inputs/Plumbing/` to `test_inputs/Scientific/` -- these become the Scientific tests; new, smaller Plumbing tests to follow separately. No truth re-seed needed for this move: `UpdateTestInputs.py` derives the GCS truth tier from the input filename/content, not from which `test_inputs/` subdirectory the file lives in, and both files' already-seeded truth already happens to sit at the paths this heuristic computes for them (`test_mouse` under `.../truth/plumbing/...`, `test_human` under `.../truth/scientific/...` -- the latter was the "known issue" from the previous entry, now moot since `test_human` actually is a Scientific test)
13+
* Added new `test_inputs/Plumbing/test_human.json` and `test_mouse.json` using Allen Institute's own MapMyCells example query files (https://brain-map.org/bkp/analyze/mapmycells/files: 1k-cell human MTG example, 10k-cell whole-mouse-brain example) staged at `gs://pd-test-storage-public/MapMyCells/input/plumbing/{human,mouse}/`, matching the `<Pipeline>/input/{plumbing,scientific}/` convention other WARP pipelines use for test data

pipelines/wdl/mapmycells/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ The task generates two output files:
3838
## Usage
3939

4040
You can find example inputs in the `test_inputs/` folder:
41-
* `test_inputs/Scientific/test_human.json` — Maps using `"Human_MTG"`
42-
* `test_inputs/Scientific/test_mouse.json`Maps using `"Mouse_WMB"`
41+
* `test_inputs/Plumbing/test_human.json` / `test_inputs/Plumbing/test_mouse.json` — small smoke tests, using Allen Institute's own [MapMyCells example files](https://brain-map.org/bkp/analyze/mapmycells/files) (1k and 10k cells respectively)
42+
* `test_inputs/Scientific/test_human.json` / `test_inputs/Scientific/test_mouse.json`full-scale runs
4343

4444
The Human_MTG and Mouse_WMB reference-atlas assets are baked into the pipeline's docker image (see [warp-tools/3rd-party-tools/mapmycells](https://github.com/broadinstitute/warp-tools/tree/develop/3rd-party-tools/mapmycells)), so you do not need to download the reference atlases or pass them into the workflow yourself. Simply specify the `reference_atlas` and provide your `query_h5ad`!
4545

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"MapMyCells.input_id": "human_mtg_example",
3+
"MapMyCells.query_h5ad": "gs://pd-test-storage-public/MapMyCells/input/plumbing/human/10xhumanmtgsea-adccn20230505_example_1kcells_36601genes.h5ad",
4+
"MapMyCells.reference_atlas": "Human_MTG",
5+
"MapMyCells.cpu": 2,
6+
"MapMyCells.memory_gb": 8
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"MapMyCells.input_id": "mouse_wmb_example",
3+
"MapMyCells.query_h5ad": "gs://pd-test-storage-public/MapMyCells/input/plumbing/mouse/wholemousebrain_ccn20230722_example_10kcells_550genes.h5ad",
4+
"MapMyCells.reference_atlas": "Mouse_WMB",
5+
"MapMyCells.cpu": 2,
6+
"MapMyCells.memory_gb": 8
7+
}

0 commit comments

Comments
 (0)