Skip to content

Stop commands sent to disabled output types on device disconnect #872

@qdot

Description

@qdot

Description

In device_handle.rs, the build_device_handle stop-command generation loop iterates all outputs on a device feature — including disabled ones. When a device disconnects or a stop-all is issued, stop commands are emitted for output types that the user has explicitly disabled in their device config.

This is inconsistent with the disabled-output policy established in bc88d3d and 839cbe3, which filter disabled outputs from client-facing messages and reject commands targeting them.

Files

  • crates/buttplug_server/src/device/device_handle.rs — stop command generation loop

Expected behavior

Stop commands should skip disabled output types, consistent with the rest of the disabled-output handling.

Context

Related fixes:

  • bc88d3d ("Filter disabled output types from client-facing DeviceFeatureOutput")
  • 839cbe3 ("Reject server-side commands targeting disabled output types")

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions