add debug cause im confused

Author: 1ceit

server/websockets/flightsWebsocket.js

@@ -22,7 +22,10 @@ export function setupFlightsWebsocket(httpServer) {
         const sessionId = socket.handshake.query.sessionId;
         const accessId = socket.handshake.query.accessId;
 
+        console.log(`[Flights Socket] Connection attempt - SessionID: ${sessionId || 'missing'}, AccessID: ${accessId ? 'provided' : 'missing'}, Socket ID: ${socket.id}`);
+
         if (!sessionId) {
+            console.warn(`[Flights Socket] Rejected connection ${socket.id} - Missing sessionId`);
             socket.disconnect(true);
             return;
         }
@@ -31,13 +34,15 @@ export function setupFlightsWebsocket(httpServer) {
         if (accessId) {
             const valid = await validateSessionAccess(sessionId, accessId);
             if (!valid) {
+                console.warn(`[Flights Socket] Rejected connection ${socket.id} - Invalid session access for sessionId: ${sessionId}`);
                 socket.disconnect(true);
                 return;
             }
             role = 'controller';
         }
         socket.data.role = role;
 
+        console.log(`[Flights Socket] Connection accepted - SessionID: ${sessionId}, Role: ${role}, Socket ID: ${socket.id}`);
         socket.join(sessionId);
 
         socket.on('updateFlight', async ({ flightId, updates }) => {
@@ -227,6 +232,10 @@ export function setupFlightsWebsocket(httpServer) {
                 socket.emit('flightError', { action: 'contactMe', flightId, error: 'Failed to send contact message' });
             }
         });
+
+        socket.on('disconnect', (reason) => {
+            console.log(`[Flights Socket] Disconnected - SessionID: ${sessionId}, Socket ID: ${socket.id}, Reason: ${reason}`);
+        });
     });
 
     return io;

src/pages/Flights.tsx

@@ -271,7 +271,7 @@ export default function Flights() {
         return () => {
             socket.socket.disconnect();
         };
-    }, [sessionId, accessId, initialLoadComplete, user, settings, accessError]);
+    }, [sessionId, accessId, initialLoadComplete, user, settings]);
     const handleIssuePDC = async (
         flightId: string | number,
         pdcText: string
@@ -474,11 +474,12 @@ export default function Flights() {
             (f) => f.id === flightId
         );
 
-        if (isExternalArrival && arrivalsSocket) {
+        if (isExternalArrival && arrivalsSocket?.socket?.connected) {
             arrivalsSocket.updateArrival(flightId, updates);
-        } else if (flightsSocket) {
+        } else if (flightsSocket?.socket?.connected) {
             flightsSocket.updateFlight(flightId, updates);
         } else {
+            console.warn('Socket not connected, updating local state only');
             setFlights((prev) =>
                 prev.map((flight) =>
                     flight.id === flightId ? { ...flight, ...updates } : flight
@@ -511,9 +512,10 @@ export default function Flights() {
         }
 
         // Regular flight deletion via WebSocket
-        if (flightsSocket) {
+        if (flightsSocket?.socket?.connected) {
             flightsSocket.deleteFlight(flightId);
         } else {
+            console.warn('Socket not connected, updating local state only');
             setFlights((prev) =>
                 prev.filter((flight) => flight.id !== flightId)
             );
@@ -573,8 +575,10 @@ export default function Flights() {
             setSession((prev) =>
                 prev ? { ...prev, activeRunway: selectedRunway } : null
             );
-            if (flightsSocket) {
+            if (flightsSocket?.socket?.connected) {
                 flightsSocket.updateSession({ activeRunway: selectedRunway });
+            } else {
+                console.warn('Socket not connected, runway updated via API only');
             }
         } catch (error) {
             console.error('Failed to update runway:', error);

src/sockets/flightsSocket.ts

@@ -14,13 +14,34 @@ export function createFlightsSocket(
     const socket = io(SOCKET_URL, {
         withCredentials: true,
         path: '/sockets/flights',
-        query: { sessionId, accessId }
+        query: { sessionId, accessId },
+        reconnection: true,
+        reconnectionDelay: 1000,
+        reconnectionAttempts: 5,
+        timeout: 10000
+    });
+
+    // Add error handlers for better debugging
+    socket.on('connect_error', (error) => {
+        console.error('Socket connection error:', error.message);
+    });
+
+    socket.on('error', (error) => {
+        console.error('Socket error:', error);
+    });
+
+    socket.on('disconnect', (reason) => {
+        console.log('Socket disconnected:', reason);
+        if (reason === 'io server disconnect') {
+            // Server disconnected the socket, try to reconnect manually
+            socket.connect();
+        }
     });
 
     socket.on('flightUpdated', onFlightUpdated);
     socket.on('flightAdded', onFlightAdded);
     socket.on('flightDeleted', onFlightDeleted);
-    
+
     if (onFlightError) {
         socket.on('flightError', onFlightError);
     }