Skip to content

Commit 5bb9840

Browse files
committed
refactor: eliminate duplicate test execution in release workflow
- Remove redundant task - no unique value over GitHub Actions - Remove redundant test job from release workflow - Tests are already validated in PR workflow before merge to main - Streamlines release workflow to focus only on releasing - Reduces CI resource usage and execution time This eliminates the duplicate test runs that were occurring: 1. PR workflow: comprehensive testing (kept) 2. Release workflow: duplicate testing (removed) Now release workflow only does semantic release after PR validation.
1 parent 3098fbc commit 5bb9840

2 files changed

Lines changed: 0 additions & 41 deletions

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -13,46 +13,9 @@ permissions:
1313
pull-requests: write
1414

1515
jobs:
16-
test:
17-
name: Test Before Release
18-
runs-on: ubuntu-latest
19-
steps:
20-
- name: Checkout code
21-
uses: actions/checkout@v4
22-
23-
- name: Setup Python
24-
uses: actions/setup-python@v4
25-
with:
26-
python-version: "3.9"
27-
28-
- name: Install Poetry
29-
uses: abatilo/actions-poetry@v3
30-
with:
31-
poetry-version: latest
32-
33-
- name: Configure Poetry
34-
run: |
35-
poetry config virtualenvs.create true --local
36-
poetry config virtualenvs.in-project true --local
37-
38-
- name: Install Task
39-
uses: arduino/setup-task@v1
40-
with:
41-
version: 3.x
42-
repo-token: ${{ secrets.GITHUB_TOKEN }}
43-
44-
- name: Install BATS
45-
run: |
46-
sudo apt-get update
47-
sudo apt-get install -y bats
48-
49-
- name: Install dependencies and run checks
50-
run: task release:prepare
51-
5216
release:
5317
name: Semantic Release
5418
runs-on: ubuntu-latest
55-
needs: test
5619
if: github.ref == 'refs/heads/main'
5720
outputs:
5821
released: ${{ steps.release.outputs.released }}

Taskfile.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,6 @@ tasks:
7777
deps: [lint, test, "static-analysis"]
7878

7979

80-
release:prepare:
81-
desc: Prepare for release (run all checks)
82-
deps: [check]
83-
8480
release:version:
8581
desc: Check what the next version would be
8682
cmds:

0 commit comments

Comments
 (0)